chatterino2
Code Issues

fix: comparison of integers of different signs (#6749)

Browse Source 
The `targetIndex` (`int`) was compared to `maxIndex` (`size_t`). This
generated a large warning, because it was in a lambda. Since we parse
`targetIndex`, we can parse it as a `size_t`.
This commit is contained in:
Nerixyz
2026-01-18 11:48:42 +01:00
committed by GitHub
parent 2d298e7e38
commit 00c6905a46
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1 -1
View File
@@ -18,7 +18,7 @@
- Minor: Added a setting to show the stream title in live messages. (#6572) - Minor: Added a setting to show the stream title in live messages. (#6572)
- Minor: Add categories to the emoji viewer. (#6598) - Minor: Add categories to the emoji viewer. (#6598)
- Minor: Added broadcaster-only `/poll`, `/cancelpoll`, and `/endpoll` commands. (#6583, #6605) - Minor: Added broadcaster-only `/poll`, `/cancelpoll`, and `/endpoll` commands. (#6583, #6605)
- Minor: Added broadcaster-only `/prediction`, `/cancelprediction`, `/lockprediction`, and `/completeprediction` commands. (#6583, #6612, #6632) - Minor: Added broadcaster-only `/prediction`, `/cancelprediction`, `/lockprediction`, and `/completeprediction` commands. (#6583, #6612, #6632, #6749)
- Minor: Added support for BetterTTV Pro subscriber badges. (#6625, #6724) - Minor: Added support for BetterTTV Pro subscriber badges. (#6625, #6724)
- Minor: Added `debug.traceback` for plugins. (#6652) - Minor: Added `debug.traceback` for plugins. (#6652)
- Minor: Added title and duration options for `/clip` command. (#6669) - Minor: Added title and duration options for `/clip` command. (#6669)
src/controllers/commands/builtin/twitch/Prediction.cpp
+3 -3
View File
@@ -280,7 +280,7 @@ QString completePrediction(const CommandContext &ctx)
return ""; return "";
} }
int targetIndex = 0; size_t targetIndex = 0;
QString targetName; QString targetName;
if (hasName) if (hasName)
{ {
@@ -289,8 +289,8 @@ QString completePrediction(const CommandContext &ctx)
else else
{ {
bool ok = true; bool ok = true;
targetIndex = parser.value(indexOption).toInt(&ok); targetIndex = parser.value(indexOption).toULongLong(&ok);
if (!ok || targetIndex <= 0) if (!ok || targetIndex == 0)
{ {
ctx.channel->addSystemMessage("Invalid index - " + usage); ctx.channel->addSystemMessage("Invalid index - " + usage);
return ""; return "";