chatterino2
Code Issues

clang-tidy: use std::move where applicable (#2605)

Browse Source 
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
Yoitsu
2021-04-10 15:34:40 +03:00
committed by GitHub
parent b0fee78f2b
commit 00ccdbc781
20 changed files with 39 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/providers/twitch/api/Helix.cpp
+12 -11
View File
@@ -58,7 +58,7 @@ void Helix::getUserByName(QString userName,
HelixFailureCallback failureCallback)
{
QStringList userIds;
QStringList userLogins{userName};
QStringList userLogins{std::move(userName)};
this->fetchUsers(
userIds, userLogins,
@@ -78,7 +78,7 @@ void Helix::getUserById(QString userId,
ResultCallback<HelixUser> successCallback,
HelixFailureCallback failureCallback)
{
QStringList userIds{userId};
QStringList userIds{std::move(userId)};
QStringList userLogins;
this->fetchUsers(
@@ -136,7 +136,8 @@ void Helix::getUserFollowers(
QString userId, ResultCallback<HelixUsersFollowsResponse> successCallback,
HelixFailureCallback failureCallback)
{
this->fetchUsersFollows("", userId, successCallback, failureCallback);
this->fetchUsersFollows("", std::move(userId), std::move(successCallback),
std::move(failureCallback));
}
void Helix::getUserFollow(
@@ -145,7 +146,7 @@ void Helix::getUserFollow(
HelixFailureCallback failureCallback)
{
this->fetchUsersFollows(
userId, targetId,
std::move(userId), std::move(targetId),
[successCallback](const auto &response) {
if (response.data.empty())
{
@@ -155,7 +156,7 @@ void Helix::getUserFollow(
successCallback(true, response.data[0]);
},
failureCallback);
std::move(failureCallback));
}
void Helix::fetchStreams(
@@ -209,7 +210,7 @@ void Helix::getStreamById(QString userId,
ResultCallback<bool, HelixStream> successCallback,
HelixFailureCallback failureCallback)
{
QStringList userIds{userId};
QStringList userIds{std::move(userId)};
QStringList userLogins;
this->fetchStreams(
@@ -230,7 +231,7 @@ void Helix::getStreamByName(QString userName,
HelixFailureCallback failureCallback)
{
QStringList userIds;
QStringList userLogins{userName};
QStringList userLogins{std::move(userName)};
this->fetchStreams(
userIds, userLogins,
@@ -299,7 +300,7 @@ void Helix::getGameById(QString gameId,
ResultCallback<HelixGame> successCallback,
HelixFailureCallback failureCallback)
{
QStringList gameIds{gameId};
QStringList gameIds{std::move(gameId)};
QStringList gameNames;
this->fetchGames(
@@ -409,7 +410,7 @@ void Helix::createClip(QString channelId,
break;
}
})
.finally(finallyCallback)
.finally(std::move(finallyCallback))
.execute();
}
@@ -653,8 +654,8 @@ NetworkRequest Helix::makeRequest(QString url, QUrlQuery urlQuery)
void Helix::update(QString clientId, QString oauthToken)
{
this->clientId = clientId;
this->oauthToken = oauthToken;
this->clientId = std::move(clientId);
this->oauthToken = std::move(oauthToken);
}
void Helix::initialize()