Sort and force grouping of includes (#4172)

This change enforces strict include grouping using IncludeCategories

In addition to adding this to the .clang-format file and applying it in the tests/src and src directories, I also did the following small changes:

    In ChatterSet.hpp, I changed lrucache to a <>include
    In Irc2.hpp, I change common/SignalVector.hpp to a "project-include"
    In AttachedWindow.cpp, NativeMessaging.cpp, WindowsHelper.hpp, BaseWindow.cpp, and StreamerMode.cpp, I disabled clang-format for the windows-includes
    In WindowDescriptors.hpp, I added the missing vector include. It was previously not needed because the include was handled by another file that was previously included first.
    clang-format minimum version has been bumped, so Ubuntu version used in the check-formatting job has been bumped to 22.04 (which is the latest LTS)
This commit is contained in:
pajlada
2022-11-27 19:32:53 +01:00
committed by GitHub
parent f2b35fb7dc
commit 032f290767
247 changed files with 658 additions and 566 deletions
+7 -6
View File
@@ -1,15 +1,16 @@
#pragma once
#include <IrcMessage>
#include <functional>
#include <mutex>
#include <pajlada/signals/signal.hpp>
#include <pajlada/signals/signalholder.hpp>
#include "common/Common.hpp"
#include "providers/irc/IrcConnection2.hpp"
#include "util/RatelimitBucket.hpp"
#include <IrcMessage>
#include <pajlada/signals/signal.hpp>
#include <pajlada/signals/signalholder.hpp>
#include <functional>
#include <mutex>
namespace chatterino {
class Channel;
+1 -1
View File
@@ -1,6 +1,5 @@
#include "Irc2.hpp"
#include <pajlada/serialize.hpp>
#include "common/Credentials.hpp"
#include "common/SignalVectorModel.hpp"
#include "singletons/Paths.hpp"
@@ -8,6 +7,7 @@
#include "util/RapidjsonHelpers.hpp"
#include "util/StandardItemHelper.hpp"
#include <pajlada/serialize.hpp>
#include <QSaveFile>
#include <QtConcurrent>
+3 -3
View File
@@ -1,11 +1,11 @@
#pragma once
#include <rapidjson/rapidjson.h>
#include <common/SignalVector.hpp>
#include "common/SignalVector.hpp"
#include "providers/irc/IrcChannel2.hpp"
#include "providers/irc/IrcServer.hpp"
#include <rapidjson/rapidjson.h>
class QAbstractTableModel;
namespace chatterino {
+2 -1
View File
@@ -1,8 +1,9 @@
#pragma once
#include <QString>
#include "common/Outcome.hpp"
#include <QString>
namespace chatterino {
class IrcChannel;
+1 -2
View File
@@ -2,9 +2,8 @@
#include "util/ExponentialBackoff.hpp"
#include <pajlada/signals/signal.hpp>
#include <IrcConnection>
#include <pajlada/signals/signal.hpp>
#include <QTimer>
namespace chatterino {
+3 -3
View File
@@ -1,8 +1,5 @@
#include "IrcServer.hpp"
#include <cassert>
#include <cstdlib>
#include "common/QLogging.hpp"
#include "messages/Message.hpp"
#include "messages/MessageColor.hpp"
@@ -17,6 +14,9 @@
#include <QMetaEnum>
#include <cassert>
#include <cstdlib>
namespace chatterino {
IrcServer::IrcServer(const IrcServerData &data)