Sort and force grouping of includes (#4172)

This change enforces strict include grouping using IncludeCategories

In addition to adding this to the .clang-format file and applying it in the tests/src and src directories, I also did the following small changes:

    In ChatterSet.hpp, I changed lrucache to a <>include
    In Irc2.hpp, I change common/SignalVector.hpp to a "project-include"
    In AttachedWindow.cpp, NativeMessaging.cpp, WindowsHelper.hpp, BaseWindow.cpp, and StreamerMode.cpp, I disabled clang-format for the windows-includes
    In WindowDescriptors.hpp, I added the missing vector include. It was previously not needed because the include was handled by another file that was previously included first.
    clang-format minimum version has been bumped, so Ubuntu version used in the check-formatting job has been bumped to 22.04 (which is the latest LTS)

src/singletons/Badges.hpp

@@ -1,9 +1,10 @@
 #pragma once
 
-#include <unordered_map>
 #include "common/Singleton.hpp"
 #include "messages/Emote.hpp"
 
+#include <unordered_map>
+
 namespace chatterino {
 
 class Badges : public Singleton

src/singletons/Emotes.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "common/Singleton.hpp"
-
 #include "providers/bttv/BttvEmotes.hpp"
 #include "providers/emoji/Emojis.hpp"
 #include "providers/ffz/FfzEmotes.hpp"

src/singletons/Fonts.hpp

@@ -3,11 +3,11 @@
 #include "common/ChatterinoSetting.hpp"
 #include "common/Singleton.hpp"
 
+#include <boost/noncopyable.hpp>
+#include <pajlada/signals/signal.hpp>
 #include <QFont>
 #include <QFontDatabase>
 #include <QFontMetrics>
-#include <boost/noncopyable.hpp>
-#include <pajlada/signals/signal.hpp>
 
 #include <array>
 #include <unordered_map>

src/singletons/Logging.cpp

@@ -1,9 +1,9 @@
 #include "singletons/Logging.hpp"
 
 #include "Application.hpp"
+#include "singletons/helper/LoggingChannel.hpp"
 #include "singletons/Paths.hpp"
 #include "singletons/Settings.hpp"
-#include "singletons/helper/LoggingChannel.hpp"
 
 #include <QDir>
 #include <QStandardPaths>

src/singletons/Logging.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "common/Singleton.hpp"
-
 #include "messages/Message.hpp"
 #include "singletons/helper/LoggingChannel.hpp"
 

src/singletons/NativeMessaging.cpp

@@ -6,6 +6,8 @@
 #include "singletons/Paths.hpp"
 #include "util/PostToThread.hpp"
 
+#include <boost/date_time/posix_time/posix_time.hpp>
+#include <boost/interprocess/ipc/message_queue.hpp>
 #include <QCoreApplication>
 #include <QFile>
 #include <QJsonArray>
@@ -13,15 +15,13 @@
 #include <QJsonObject>
 #include <QJsonValue>
 
-#include <boost/date_time/posix_time/posix_time.hpp>
-#include <boost/interprocess/ipc/message_queue.hpp>
-
 namespace ipc = boost::interprocess;
 
 #ifdef Q_OS_WIN
+// clang-format off
 #    include <QSettings>
-
 #    include <Windows.h>
+// clang-format on
 #    include "singletons/WindowManager.hpp"
 #    include "widgets/AttachedWindow.hpp"
 #endif

src/singletons/NativeMessaging.hpp

@@ -1,9 +1,9 @@
 #pragma once
 
-#include <QString>
-#include <QThread>
 #include <boost/optional.hpp>
 #include <common/Atomic.hpp>
+#include <QString>
+#include <QThread>
 
 namespace chatterino {
 

src/singletons/Paths.cpp

@@ -1,15 +1,15 @@
 #include "singletons/Paths.hpp"
 
+#include "common/Modes.hpp"
 #include "singletons/Settings.hpp"
+#include "util/CombinePath.hpp"
 
 #include <QCoreApplication>
 #include <QCryptographicHash>
 #include <QDir>
 #include <QStandardPaths>
-#include <cassert>
 
-#include "common/Modes.hpp"
-#include "util/CombinePath.hpp"
+#include <cassert>
 
 using namespace std::literals;
 

src/singletons/Paths.hpp

@@ -1,7 +1,7 @@
 #pragma once
 
-#include <QString>
 #include <boost/optional.hpp>
+#include <QString>
 
 namespace chatterino {
 

src/singletons/Settings.hpp

@@ -1,8 +1,5 @@
 #pragma once
 
-#include <pajlada/settings/setting.hpp>
-#include <pajlada/settings/settinglistener.hpp>
-
 #include "BaseSettings.hpp"
 #include "common/Channel.hpp"
 #include "common/SignalVector.hpp"
@@ -16,6 +13,9 @@
 #include "widgets/Notebook.hpp"
 #include "widgets/splits/SplitInput.hpp"
 
+#include <pajlada/settings/setting.hpp>
+#include <pajlada/settings/settinglistener.hpp>
+
 using TimeoutButton = std::pair<QString, int>;
 
 namespace chatterino {

src/singletons/Theme.hpp

@@ -3,9 +3,9 @@
 #include "common/Singleton.hpp"
 #include "util/RapidJsonSerializeQString.hpp"
 
+#include <pajlada/settings/setting.hpp>
 #include <QBrush>
 #include <QColor>
-#include <pajlada/settings/setting.hpp>
 #include <singletons/Settings.hpp>
 
 namespace chatterino {

src/singletons/Toasts.cpp

@@ -4,10 +4,10 @@
 #include "common/DownloadManager.hpp"
 #include "common/NetworkRequest.hpp"
 #include "controllers/notifications/NotificationController.hpp"
+#include "providers/twitch/api/Helix.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
 #include "providers/twitch/TwitchCommon.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"
-#include "providers/twitch/api/Helix.hpp"
 #include "singletons/Paths.hpp"
 #include "util/StreamLink.hpp"
 #include "widgets/helper/CommonTexts.hpp"

src/singletons/Updates.cpp

@@ -1,10 +1,11 @@
 #include "Updates.hpp"
 
-#include "Settings.hpp"
 #include "common/Modes.hpp"
 #include "common/NetworkRequest.hpp"
 #include "common/Outcome.hpp"
+#include "common/QLogging.hpp"
 #include "common/Version.hpp"
+#include "Settings.hpp"
 #include "singletons/Paths.hpp"
 #include "util/CombinePath.hpp"
 #include "util/PostToThread.hpp"
@@ -13,7 +14,6 @@
 #include <QMessageBox>
 #include <QProcess>
 #include <QRegularExpression>
-#include "common/QLogging.hpp"
 
 namespace chatterino {
 namespace {

src/singletons/Updates.hpp

@@ -1,7 +1,7 @@
 #pragma once
 
-#include <QString>
 #include <pajlada/signals/signal.hpp>
+#include <QString>
 
 namespace chatterino {
 

src/singletons/WindowManager.cpp

@@ -1,17 +1,5 @@
 #include "singletons/WindowManager.hpp"
 
-#include <QDebug>
-#include <QDesktopWidget>
-#include <QJsonArray>
-#include <QJsonDocument>
-#include <QJsonObject>
-#include <QMessageBox>
-#include <QSaveFile>
-#include <QScreen>
-#include <boost/optional.hpp>
-#include <chrono>
-
-#include <QMessageBox>
 #include "Application.hpp"
 #include "common/Args.hpp"
 #include "common/QLogging.hpp"
@@ -28,13 +16,25 @@
 #include "util/Clamp.hpp"
 #include "util/CombinePath.hpp"
 #include "widgets/AccountSwitchPopup.hpp"
-#include "widgets/FramelessEmbedWindow.hpp"
-#include "widgets/Notebook.hpp"
-#include "widgets/Window.hpp"
 #include "widgets/dialogs/SettingsDialog.hpp"
+#include "widgets/FramelessEmbedWindow.hpp"
 #include "widgets/helper/NotebookTab.hpp"
+#include "widgets/Notebook.hpp"
 #include "widgets/splits/Split.hpp"
 #include "widgets/splits/SplitContainer.hpp"
+#include "widgets/Window.hpp"
+
+#include <boost/optional.hpp>
+#include <QDebug>
+#include <QDesktopWidget>
+#include <QJsonArray>
+#include <QJsonDocument>
+#include <QJsonObject>
+#include <QMessageBox>
+#include <QSaveFile>
+#include <QScreen>
+
+#include <chrono>
 
 namespace chatterino {
 namespace {

src/singletons/WindowManager.hpp

@@ -1,14 +1,14 @@
 #pragma once
 
-#include <memory>
 #include "common/Channel.hpp"
 #include "common/FlagsEnum.hpp"
 #include "common/Singleton.hpp"
 #include "common/WindowDescriptors.hpp"
-
 #include "pajlada/settings/settinglistener.hpp"
 #include "widgets/splits/SplitContainer.hpp"
 
+#include <memory>
+
 namespace chatterino {
 
 class Settings;

src/singletons/helper/GifTimer.hpp

@@ -1,7 +1,7 @@
 #pragma once
 
-#include <QTimer>
 #include <pajlada/signals/signal.hpp>
+#include <QTimer>
 
 namespace chatterino {
 

src/singletons/helper/LoggingChannel.hpp

@@ -2,10 +2,10 @@
 
 #include "messages/Message.hpp"
 
+#include <boost/noncopyable.hpp>
 #include <QDateTime>
 #include <QFile>
 #include <QString>
-#include <boost/noncopyable.hpp>
 
 #include <memory>