fix: ReplyThreadPopup now requires a split as its parent (#5036)

Co-authored-by: Nerixyz <nerixdev@outlook.de>

src/widgets/dialogs/ReplyThreadPopup.cpp

@@ -24,11 +24,12 @@ const QString TEXT_TITLE("Reply Thread - @%1 in #%2");
 
 namespace chatterino {
 
-ReplyThreadPopup::ReplyThreadPopup(bool closeAutomatically, QWidget *parent,
-                                   Split *split)
-    : DraggablePopup(closeAutomatically, parent)
+ReplyThreadPopup::ReplyThreadPopup(bool closeAutomatically, Split *split)
+    : DraggablePopup(closeAutomatically, split)
     , split_(split)
 {
+    assert(split != nullptr);
+
     this->setWindowTitle(QStringLiteral("Reply Thread"));
 
     HotkeyController::HotkeyMap actions{

src/widgets/dialogs/ReplyThreadPopup.hpp

@@ -20,7 +20,11 @@ class ReplyThreadPopup final : public DraggablePopup
     Q_OBJECT
 
 public:
-    ReplyThreadPopup(bool closeAutomatically, QWidget *parent, Split *split);
+    /**
+     * @param closeAutomatically Decides whether the popup should close when it loses focus
+     * @param split Will be used as the popup's parent. Must not be null
+     */
+    explicit ReplyThreadPopup(bool closeAutomatically, Split *split);
 
     void setThread(std::shared_ptr<MessageThread> thread);
     void giveFocus(Qt::FocusReason reason);