chatterino2
Code Issues

refactor: simplify uses of getMessageSnapshot (#6607)

Browse Source 
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
nerix
2025-11-29 12:40:06 +01:00
committed by GitHub
parent 6756374b5b
commit 041674b7f6
9 changed files with 31 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/dialogs/EmotePopup.cpp
+1 -1
View File
@@ -483,7 +483,7 @@ void EmotePopup::reloadEmotes()
"7TV");
}
if (subChannel->getMessageSnapshot().size() == 0)
if (!subChannel->hasMessages())
{
MessageBuilder builder;
builder->flags.set(MessageFlag::Centered);
src/widgets/dialogs/UserInfoPopup.cpp
+1 -3
View File
@@ -121,10 +121,8 @@ ChannelPtr filterMessages(const QString &userName, ChannelPtr channel)
std::make_shared<Channel>(channel->getName(), Channel::Type::None);
}
for (size_t i = 0; i < snapshot.size(); i++)
for (const auto &message : snapshot)
{
MessagePtr message = snapshot[i];
if (checkMessageUserName(userName, message))
{
channelPtr->addMessage(message, MessageContext::Repost);
src/widgets/helper/SearchPopup.cpp
+1 -1
View File
@@ -248,7 +248,7 @@ std::vector<MessagePtr> SearchPopup::buildSnapshot()
ChannelView &sharedView = channel.get();
const FilterSetPtr filterSet = sharedView.getFilterSet();
const std::vector<MessagePtr> &snapshot =
std::vector<MessagePtr> snapshot =
sharedView.channel()->getMessageSnapshot();
for (const auto &message : snapshot)