From 052dbd7d2cc2a25d832e675443b68d0643cfdd9d Mon Sep 17 00:00:00 2001 From: nerix Date: Wed, 19 Jun 2024 14:46:54 +0200 Subject: [PATCH] fix: check state when completing commands (#5401) --- CHANGELOG.md | 1 + src/controllers/plugins/PluginController.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d799002..141124c4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ - Bugfix: Fixed restricted users usernames not being clickable. (#5405) - Bugfix: Fixed a crash that could occur when logging was enabled in IRC servers that were removed. (#5419) - Bugfix: Fixed message history occasionally not loading after a sleep. (#5457) +- Bugfix: Fixed a crash when tab completing while having an invalid plugin loaded. (#5401) - Dev: Update Windows build from Qt 6.5.0 to Qt 6.7.1. (#5420) - Dev: Update vcpkg build Qt from 6.5.0 to 6.7.0, boost from 1.83.0 to 1.85.0, openssl from 3.1.3 to 3.3.0. (#5422) - Dev: Unsingletonize `ISoundController`. (#5462) diff --git a/src/controllers/plugins/PluginController.cpp b/src/controllers/plugins/PluginController.cpp index 8c2d8055..199e0f4e 100644 --- a/src/controllers/plugins/PluginController.cpp +++ b/src/controllers/plugins/PluginController.cpp @@ -420,7 +420,7 @@ std::pair PluginController::updateCustomCompletions( for (const auto &[name, pl] : this->plugins()) { - if (!pl->error().isNull()) + if (!pl->error().isNull() || pl->state_ == nullptr) { continue; }