chatterino2
Code Issues

fix(websockets): add query to URL (#6141)

Browse Source 
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
nerix
2025-11-02 16:07:58 +01:00
committed by GitHub
parent e4a4d812e3
commit 072bc897a0
7 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/WebSocketPool.cpp
+9 -3
View File
@@ -61,7 +61,7 @@ TEST(WebSocketPool, tcpEcho)
auto handle = pool.createSocket(
{
.url = QUrl("ws://127.0.0.1:9052/echo"),
.url = QUrl("ws://127.0.0.1:9052/echo?query=123&xd=wow"),
.headers =
{
{"My-Header", "my-header-VALUE"},
@@ -85,11 +85,12 @@ TEST(WebSocketPool, tcpEcho)
handle.sendText("/HEADER another-header");
handle.sendText("/HEADER cookie");
handle.sendText("/HEADER user-agent");
handle.sendText("/URL");
handle.sendText("/CLOSE");
ASSERT_TRUE(closeFlag.waitFor(1s));
ASSERT_EQ(messages.size(), 10);
ASSERT_EQ(messages.size(), 11);
ASSERT_EQ(messages[0].first, false);
ASSERT_EQ(messages[0].second, "message1");
ASSERT_EQ(messages[1].first, false);
@@ -110,6 +111,8 @@ TEST(WebSocketPool, tcpEcho)
ASSERT_EQ(messages[8].second, "xd");
ASSERT_EQ(messages[9].first, true);
ASSERT_EQ(messages[9].second, "MyUserAgent");
ASSERT_EQ(messages[10].first, true);
ASSERT_EQ(messages[10].second, "/echo?query=123&xd=wow");
}
TEST(WebSocketPool, tlsEcho)
@@ -146,11 +149,12 @@ TEST(WebSocketPool, tlsEcho)
handle.sendText("/HEADER another-header");
handle.sendText("/HEADER cookie");
handle.sendText("/HEADER user-agent");
handle.sendText("/URL");
handle.sendText("/CLOSE");
ASSERT_TRUE(closeFlag.waitFor(1s));
ASSERT_EQ(messages.size(), 10);
ASSERT_EQ(messages.size(), 11);
ASSERT_EQ(messages[0].first, false);
ASSERT_EQ(messages[0].second, "message1");
ASSERT_EQ(messages[1].first, false);
@@ -171,4 +175,6 @@ TEST(WebSocketPool, tlsEcho)
ASSERT_EQ(messages[8].second, "xd");
ASSERT_EQ(messages[9].first, true);
ASSERT_TRUE(messages[9].second.startsWith("Chatterino"));
ASSERT_EQ(messages[10].first, true);
ASSERT_EQ(messages[10].second, "/echo");
}