Optimize formatTime utility (#3777)

Adds benchmarks and unit tests for the function Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
2022-05-29 13:54:42 +02:00
parent 143f4ef2ec
commit 0ad66c0af4
5 changed files with 183 additions and 15 deletions
@@ -0,0 +1,133 @@
+#include "util/FormatTime.hpp"
+
+#include <gtest/gtest.h>
+
+using namespace chatterino;
+
+TEST(FormatTime, Int)
+{
+    struct TestCase {
+        int input;
+        QString expectedOutput;
+    };
+
+    std::vector<TestCase> tests{
+        {
+            0,
+            "",
+        },
+        {
+            1337,
+            "22m 17s",
+        },
+        {
+            623452,
+            "7d 5h 10m 52s",
+        },
+        {
+            8345,
+            "2h 19m 5s",
+        },
+        {
+            314034,
+            "3d 15h 13m 54s",
+        },
+        {
+            27,
+            "27s",
+        },
+        {
+            34589,
+            "9h 36m 29s",
+        },
+        {
+            3659,
+            "1h 59s",
+        },
+        {
+            1045345,
+            "12d 2h 22m 25s",
+        },
+        {
+            86432,
+            "1d 32s",
+        },
+    };
+
+    for (const auto &[input, expected] : tests)
+    {
+        const auto actual = formatTime(input);
+
+        EXPECT_EQ(actual, expected)
+            << qUtf8Printable(actual) << " (" << input
+            << ") did not match expected value " << qUtf8Printable(expected);
+    }
+}
+
+TEST(FormatTime, QString)
+{
+    struct TestCase {
+        QString input;
+        QString expectedOutput;
+    };
+
+    std::vector<TestCase> tests{
+        {
+            "0",
+            "",
+        },
+        {
+            "1337",
+            "22m 17s",
+        },
+        {
+            "623452",
+            "7d 5h 10m 52s",
+        },
+        {
+            "8345",
+            "2h 19m 5s",
+        },
+        {
+            "314034",
+            "3d 15h 13m 54s",
+        },
+        {
+            "27",
+            "27s",
+        },
+        {
+            "34589",
+            "9h 36m 29s",
+        },
+        {
+            "3659",
+            "1h 59s",
+        },
+        {
+            "1045345",
+            "12d 2h 22m 25s",
+        },
+        {
+            "86432",
+            "1d 32s",
+        },
+        {
+            "",
+            "n/a",
+        },
+        {
+            "asd",
+            "n/a",
+        },
+    };
+
+    for (const auto &[input, expected] : tests)
+    {
+        const auto actual = formatTime(input);
+
+        EXPECT_EQ(actual, expected)
+            << qUtf8Printable(actual) << " (" << qUtf8Printable(input)
+            << ") did not match expected value " << qUtf8Printable(expected);
+    }
+}