Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/common/ChannelChatters.cpp

@@ -1,9 +1,12 @@
 #include "ChannelChatters.hpp"
 
+#include "common/Channel.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageBuilder.hpp"
 #include "providers/twitch/TwitchMessageBuilder.hpp"
 
+#include <QColor>
+
 namespace chatterino {
 
 ChannelChatters::ChannelChatters(Channel &channel)

src/common/ChannelChatters.hpp

@@ -1,15 +1,18 @@
 #pragma once
 
-#include "common/Channel.hpp"
 #include "common/ChatterSet.hpp"
 #include "common/UniqueAccess.hpp"
 #include "lrucache/lrucache.hpp"
 #include "util/QStringHash.hpp"
 
+#include <QColor>
+#include <QObject>
 #include <QRgb>
 
 namespace chatterino {
 
+class Channel;
+
 class ChannelChatters
 {
 public:

src/common/Common.hpp

@@ -1,9 +1,5 @@
 #pragma once
 
-#include "common/Aliases.hpp"
-#include "common/Outcome.hpp"
-#include "common/ProviderId.hpp"
-
 #include <boost/optional.hpp>
 #include <boost/preprocessor.hpp>
 #include <QString>
@@ -20,11 +16,6 @@ enum class HighlightState {
     NewMessage,
 };
 
-inline QString qS(const std::string &string)
-{
-    return QString::fromStdString(string);
-}
-
 const Qt::KeyboardModifiers showSplitOverlayModifiers =
     Qt::ControlModifier | Qt::AltModifier;
 const Qt::KeyboardModifiers showAddSplitRegions =

src/common/CompletionModel.cpp

@@ -3,6 +3,7 @@
 #include "Application.hpp"
 #include "common/ChatterSet.hpp"
 #include "controllers/accounts/AccountController.hpp"
+#include "controllers/commands/Command.hpp"
 #include "controllers/commands/CommandController.hpp"
 #include "messages/Emote.hpp"
 #include "providers/twitch/TwitchAccount.hpp"

src/common/DownloadManager.hpp

@@ -3,9 +3,7 @@
 #include <QFile>
 #include <QNetworkAccessManager>
 #include <QNetworkReply>
-#include <QNetworkRequest>
 #include <QObject>
-#include <QStringList>
 
 namespace chatterino {
 

src/common/LinkParser.hpp

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <QRegularExpressionMatch>
 #include <QString>
 
 namespace chatterino {

src/common/NetworkRequest.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "common/NetworkCommon.hpp"
-#include "common/NetworkResult.hpp"
 
 #include <QHttpMultiPart>
 

src/common/SignalVectorModel.hpp

@@ -10,6 +10,12 @@
 
 namespace chatterino {
 
+template <typename T>
+class SignalVector;
+
+template <typename T>
+struct SignalVectorItemEvent;
+
 template <typename TVectorItem>
 class SignalVectorModel : public QAbstractTableModel,
                           pajlada::Signals::SignalHolder