Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/controllers/commands/CommandContext.hpp

@@ -1,12 +1,15 @@
 #pragma once
 
-#include "common/Channel.hpp"
-#include "providers/twitch/TwitchChannel.hpp"
-
 #include <QStringList>
 
+#include <memory>
+
 namespace chatterino {
 
+class Channel;
+using ChannelPtr = std::shared_ptr<Channel>;
+class TwitchChannel;
+
 struct CommandContext {
     QStringList words;
 

src/controllers/commands/CommandController.cpp

@@ -1,21 +1,25 @@
-#include "CommandController.hpp"
+#include "controllers/commands/CommandController.hpp"
 
 #include "Application.hpp"
 #include "common/Env.hpp"
+#include "common/NetworkResult.hpp"
 #include "common/QLogging.hpp"
 #include "common/SignalVector.hpp"
 #include "controllers/accounts/AccountController.hpp"
 #include "controllers/commands/builtin/twitch/ChatSettings.hpp"
 #include "controllers/commands/Command.hpp"
+#include "controllers/commands/CommandContext.hpp"
 #include "controllers/commands/CommandModel.hpp"
 #include "controllers/userdata/UserDataController.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageBuilder.hpp"
 #include "messages/MessageElement.hpp"
+#include "messages/MessageThread.hpp"
 #include "providers/irc/IrcChannel2.hpp"
 #include "providers/irc/IrcServer.hpp"
 #include "providers/twitch/api/Helix.hpp"
 #include "providers/twitch/TwitchAccount.hpp"
+#include "providers/twitch/TwitchChannel.hpp"
 #include "providers/twitch/TwitchCommon.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"
 #include "providers/twitch/TwitchMessageBuilder.hpp"
@@ -35,6 +39,7 @@
 #include "util/Twitch.hpp"
 #include "widgets/dialogs/ReplyThreadPopup.hpp"
 #include "widgets/dialogs/UserInfoPopup.hpp"
+#include "widgets/helper/ChannelView.hpp"
 #include "widgets/splits/Split.hpp"
 #include "widgets/splits/SplitContainer.hpp"
 #include "widgets/Window.hpp"

src/controllers/commands/CommandController.hpp

@@ -1,11 +1,8 @@
 #pragma once
 
-#include "common/ChatterinoSetting.hpp"
 #include "common/SignalVector.hpp"
 #include "common/Singleton.hpp"
-#include "controllers/commands/Command.hpp"
-#include "controllers/commands/CommandContext.hpp"
-#include "providers/twitch/TwitchChannel.hpp"
+#include "util/QStringHash.hpp"
 
 #include <pajlada/settings.hpp>
 #include <QMap>
@@ -20,8 +17,12 @@ namespace chatterino {
 class Settings;
 class Paths;
 class Channel;
+using ChannelPtr = std::shared_ptr<Channel>;
+struct Message;
 
+struct Command;
 class CommandModel;
+struct CommandContext;
 
 class CommandController final : public Singleton
 {

src/controllers/commands/CommandModel.cpp

@@ -1,5 +1,7 @@
-#include "CommandModel.hpp"
+#include "controllers/commands/CommandModel.hpp"
 
+#include "common/SignalVector.hpp"
+#include "controllers/commands/Command.hpp"
 #include "util/StandardItemHelper.hpp"
 
 namespace chatterino {

src/controllers/commands/CommandModel.hpp

@@ -1,13 +1,13 @@
 #pragma once
 
 #include "common/SignalVectorModel.hpp"
-#include "controllers/commands/Command.hpp"
 
 #include <QObject>
 
 namespace chatterino {
 
 class CommandController;
+struct Command;
 
 class CommandModel : public SignalVectorModel<Command>
 {

src/controllers/commands/builtin/twitch/ChatSettings.cpp

@@ -2,6 +2,7 @@
 
 #include "Application.hpp"
 #include "controllers/accounts/AccountController.hpp"
+#include "controllers/commands/CommandContext.hpp"
 #include "messages/MessageBuilder.hpp"
 #include "providers/twitch/api/Helix.hpp"
 #include "providers/twitch/TwitchAccount.hpp"

src/controllers/commands/builtin/twitch/ChatSettings.hpp

@@ -1,24 +1,28 @@
 #pragma once
 
-#include "controllers/commands/CommandContext.hpp"
-
 #include <QString>
 
-namespace chatterino::commands {
+namespace chatterino {
 
-QString emoteOnly(const CommandContext &ctx);
-QString emoteOnlyOff(const CommandContext &ctx);
+struct CommandContext;
 
-QString subscribers(const CommandContext &ctx);
-QString subscribersOff(const CommandContext &ctx);
+namespace commands {
 
-QString slow(const CommandContext &ctx);
-QString slowOff(const CommandContext &ctx);
+    QString emoteOnly(const CommandContext &ctx);
+    QString emoteOnlyOff(const CommandContext &ctx);
 
-QString followers(const CommandContext &ctx);
-QString followersOff(const CommandContext &ctx);
+    QString subscribers(const CommandContext &ctx);
+    QString subscribersOff(const CommandContext &ctx);
 
-QString uniqueChat(const CommandContext &ctx);
-QString uniqueChatOff(const CommandContext &ctx);
+    QString slow(const CommandContext &ctx);
+    QString slowOff(const CommandContext &ctx);
 
-}  // namespace chatterino::commands
+    QString followers(const CommandContext &ctx);
+    QString followersOff(const CommandContext &ctx);
+
+    QString uniqueChat(const CommandContext &ctx);
+    QString uniqueChatOff(const CommandContext &ctx);
+
+}  // namespace commands
+
+}  // namespace chatterino