Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/controllers/commands/builtin/twitch/ChatSettings.cpp

@@ -2,6 +2,7 @@
 
 #include "Application.hpp"
 #include "controllers/accounts/AccountController.hpp"
+#include "controllers/commands/CommandContext.hpp"
 #include "messages/MessageBuilder.hpp"
 #include "providers/twitch/api/Helix.hpp"
 #include "providers/twitch/TwitchAccount.hpp"

src/controllers/commands/builtin/twitch/ChatSettings.hpp

@@ -1,24 +1,28 @@
 #pragma once
 
-#include "controllers/commands/CommandContext.hpp"
-
 #include <QString>
 
-namespace chatterino::commands {
+namespace chatterino {
 
-QString emoteOnly(const CommandContext &ctx);
-QString emoteOnlyOff(const CommandContext &ctx);
+struct CommandContext;
 
-QString subscribers(const CommandContext &ctx);
-QString subscribersOff(const CommandContext &ctx);
+namespace commands {
 
-QString slow(const CommandContext &ctx);
-QString slowOff(const CommandContext &ctx);
+    QString emoteOnly(const CommandContext &ctx);
+    QString emoteOnlyOff(const CommandContext &ctx);
 
-QString followers(const CommandContext &ctx);
-QString followersOff(const CommandContext &ctx);
+    QString subscribers(const CommandContext &ctx);
+    QString subscribersOff(const CommandContext &ctx);
 
-QString uniqueChat(const CommandContext &ctx);
-QString uniqueChatOff(const CommandContext &ctx);
+    QString slow(const CommandContext &ctx);
+    QString slowOff(const CommandContext &ctx);
 
-}  // namespace chatterino::commands
+    QString followers(const CommandContext &ctx);
+    QString followersOff(const CommandContext &ctx);
+
+    QString uniqueChat(const CommandContext &ctx);
+    QString uniqueChatOff(const CommandContext &ctx);
+
+}  // namespace commands
+
+}  // namespace chatterino