Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/messages/layouts/MessageLayout.cpp

@@ -3,8 +3,11 @@
 #include "Application.hpp"
 #include "debug/Benchmark.hpp"
 #include "messages/layouts/MessageLayoutContainer.hpp"
+#include "messages/layouts/MessageLayoutElement.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageElement.hpp"
+#include "messages/Selection.hpp"
+#include "providers/colors/ColorProvider.hpp"
 #include "singletons/Emotes.hpp"
 #include "singletons/Settings.hpp"
 #include "singletons/Theme.hpp"

src/messages/layouts/MessageLayoutContainer.hpp

@@ -2,8 +2,6 @@
 
 #include "common/Common.hpp"
 #include "common/FlagsEnum.hpp"
-#include "messages/layouts/MessageLayoutElement.hpp"
-#include "messages/Selection.hpp"
 
 #include <QPoint>
 #include <QRect>
@@ -18,6 +16,8 @@ namespace chatterino {
 enum class MessageFlag : int64_t;
 enum class FirstWord { Neutral, RTL, LTR };
 using MessageFlags = FlagsEnum<MessageFlag>;
+class MessageLayoutElement;
+struct Selection;
 
 struct Margin {
     int top;

src/messages/layouts/MessageLayoutElement.hpp

@@ -2,8 +2,6 @@
 
 #include "common/FlagsEnum.hpp"
 #include "messages/Link.hpp"
-#include "messages/MessageColor.hpp"
-#include "messages/MessageElement.hpp"
 
 #include <boost/noncopyable.hpp>
 #include <pajlada/signals/signalholder.hpp>
@@ -22,6 +20,7 @@ class MessageElement;
 class Image;
 using ImagePtr = std::shared_ptr<Image>;
 enum class FontStyle : uint8_t;
+enum class MessageElementFlag : int64_t;
 
 class MessageLayoutElement : boost::noncopyable
 {