Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/messages/search/AuthorPredicate.cpp

@@ -1,5 +1,6 @@
 #include "messages/search/AuthorPredicate.hpp"
 
+#include "messages/Message.hpp"
 #include "util/Qt.hpp"
 
 namespace chatterino {

src/messages/search/AuthorPredicate.hpp

@@ -2,6 +2,9 @@
 
 #include "messages/search/MessagePredicate.hpp"
 
+#include <QString>
+#include <QStringList>
+
 namespace chatterino {
 
 /**

src/messages/search/BadgePredicate.cpp

@@ -1,5 +1,7 @@
 #include "messages/search/BadgePredicate.hpp"
 
+#include "messages/Message.hpp"
+#include "providers/twitch/TwitchBadge.hpp"
 #include "util/Qt.hpp"
 
 namespace chatterino {

src/messages/search/BadgePredicate.hpp

@@ -2,6 +2,9 @@
 
 #include "messages/search/MessagePredicate.hpp"
 
+#include <QString>
+#include <QStringList>
+
 namespace chatterino {
 
 /**

src/messages/search/ChannelPredicate.cpp

@@ -1,5 +1,6 @@
 #include "messages/search/ChannelPredicate.hpp"
 
+#include "messages/Message.hpp"
 #include "util/Qt.hpp"
 
 namespace chatterino {

src/messages/search/ChannelPredicate.hpp

@@ -2,6 +2,9 @@
 
 #include "messages/search/MessagePredicate.hpp"
 
+#include <QString>
+#include <QStringList>
+
 namespace chatterino {
 
 /**

src/messages/search/LinkPredicate.cpp

@@ -1,6 +1,7 @@
 #include "messages/search/LinkPredicate.hpp"
 
 #include "common/LinkParser.hpp"
+#include "messages/Message.hpp"
 #include "util/Qt.hpp"
 
 namespace chatterino {

src/messages/search/LinkPredicate.hpp

@@ -2,6 +2,8 @@
 
 #include "messages/search/MessagePredicate.hpp"
 
+#include <QString>
+
 namespace chatterino {
 
 /**

src/messages/search/MessageFlagsPredicate.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include "common/FlagsEnum.hpp"
+#include "messages/Message.hpp"
 #include "messages/search/MessagePredicate.hpp"
 
 namespace chatterino {

src/messages/search/MessagePredicate.hpp

@@ -1,11 +1,11 @@
 #pragma once
 
-#include "messages/Message.hpp"
-
 #include <memory>
 
 namespace chatterino {
 
+struct Message;
+
 /**
  * @brief Abstract base class for message predicates.
  *

src/messages/search/RegexPredicate.cpp

@@ -1,5 +1,7 @@
 #include "RegexPredicate.hpp"
 
+#include "messages/Message.hpp"
+
 namespace chatterino {
 
 RegexPredicate::RegexPredicate(const QString &regex, bool negate)

src/messages/search/RegexPredicate.hpp

@@ -3,6 +3,8 @@
 #include "messages/search/MessagePredicate.hpp"
 #include "QRegularExpression"
 
+#include <QString>
+
 namespace chatterino {
 
 /**

src/messages/search/SubstringPredicate.cpp

@@ -1,5 +1,7 @@
 #include "messages/search/SubstringPredicate.hpp"
 
+#include "messages/Message.hpp"
+
 namespace chatterino {
 
 SubstringPredicate::SubstringPredicate(const QString &search)

src/messages/search/SubstringPredicate.hpp

@@ -2,6 +2,8 @@
 
 #include "messages/search/MessagePredicate.hpp"
 
+#include <QString>
+
 namespace chatterino {
 
 /**

src/messages/search/SubtierPredicate.cpp

@@ -1,5 +1,7 @@
 #include "messages/search/SubtierPredicate.hpp"
 
+#include "messages/Message.hpp"
+#include "providers/twitch/TwitchBadge.hpp"
 #include "util/Qt.hpp"
 
 namespace chatterino {

src/messages/search/SubtierPredicate.hpp

@@ -2,6 +2,9 @@
 
 #include "messages/search/MessagePredicate.hpp"
 
+#include <QString>
+#include <QStringList>
+
 namespace chatterino {
 
 /**