Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/providers/bttv/BttvEmotes.cpp

@@ -1,7 +1,7 @@
 #include "providers/bttv/BttvEmotes.hpp"
 
-#include "common/Common.hpp"
 #include "common/NetworkRequest.hpp"
+#include "common/NetworkResult.hpp"
 #include "common/QLogging.hpp"
 #include "messages/Emote.hpp"
 #include "messages/Image.hpp"

src/providers/bttv/BttvEmotes.hpp

@@ -1,9 +1,9 @@
 #pragma once
 
-#include "boost/optional.hpp"
 #include "common/Aliases.hpp"
 #include "common/Atomic.hpp"
-#include "providers/twitch/TwitchChannel.hpp"
+
+#include <boost/optional.hpp>
 
 #include <memory>
 
@@ -12,6 +12,7 @@ namespace chatterino {
 struct Emote;
 using EmotePtr = std::shared_ptr<const Emote>;
 class EmoteMap;
+class Channel;
 
 class BttvEmotes final
 {

src/providers/bttv/LoadBttvChannelEmote.cpp

@@ -1,15 +0,0 @@
-#include "LoadBttvChannelEmote.hpp"
-
-#include "common/Common.hpp"
-#include "common/NetworkRequest.hpp"
-#include "common/UniqueAccess.hpp"
-#include "messages/Emote.hpp"
-
-#include <QJsonArray>
-#include <QJsonObject>
-#include <QJsonValue>
-#include <QThread>
-
-namespace chatterino {
-
-}  // namespace chatterino

src/providers/bttv/LoadBttvChannelEmote.hpp

@@ -1,9 +0,0 @@
-#pragma once
-
-#include <functional>
-
-class QString;
-
-namespace chatterino {
-
-}  // namespace chatterino