Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/providers/irc/AbstractIrcServer.cpp

@@ -1,7 +1,6 @@
 #include "AbstractIrcServer.hpp"
 
 #include "common/Channel.hpp"
-#include "common/Common.hpp"
 #include "common/QLogging.hpp"
 #include "messages/LimitedQueueSnapshot.hpp"
 #include "messages/Message.hpp"

src/providers/irc/AbstractIrcServer.hpp

@@ -15,6 +15,7 @@ namespace chatterino {
 
 class Channel;
 using ChannelPtr = std::shared_ptr<Channel>;
+class RatelimitBucket;
 
 class AbstractIrcServer : public QObject
 {

src/providers/irc/Irc2.cpp

@@ -2,6 +2,8 @@
 
 #include "common/Credentials.hpp"
 #include "common/SignalVectorModel.hpp"
+#include "providers/irc/IrcChannel2.hpp"
+#include "providers/irc/IrcServer.hpp"
 #include "singletons/Paths.hpp"
 #include "util/CombinePath.hpp"
 #include "util/RapidjsonHelpers.hpp"

src/providers/irc/Irc2.hpp

@@ -1,8 +1,6 @@
 #pragma once
 
 #include "common/SignalVector.hpp"
-#include "providers/irc/IrcChannel2.hpp"
-#include "providers/irc/IrcServer.hpp"
 
 #include <rapidjson/rapidjson.h>
 
@@ -10,6 +8,10 @@ class QAbstractTableModel;
 
 namespace chatterino {
 
+class Channel;
+using ChannelPtr = std::shared_ptr<Channel>;
+class IrcServer;
+
 enum class IrcAuthType { Anonymous, Custom, Pass, Sasl };
 
 struct IrcServerData {

src/providers/irc/IrcChannel2.cpp

@@ -3,6 +3,7 @@
 #include "debug/AssertInGuiThread.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageBuilder.hpp"
+#include "messages/MessageElement.hpp"
 #include "providers/irc/IrcCommands.hpp"
 #include "providers/irc/IrcMessageBuilder.hpp"
 #include "providers/irc/IrcServer.hpp"

src/providers/irc/IrcMessageBuilder.cpp

@@ -1,15 +1,11 @@
 #include "providers/irc/IrcMessageBuilder.hpp"
 
-#include "Application.hpp"
-#include "common/IrcColors.hpp"
-#include "controllers/accounts/AccountController.hpp"
 #include "controllers/ignores/IgnoreController.hpp"
 #include "controllers/ignores/IgnorePhrase.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageColor.hpp"
-#include "providers/chatterino/ChatterinoBadges.hpp"
+#include "messages/MessageElement.hpp"
 #include "singletons/Emotes.hpp"
-#include "singletons/Resources.hpp"
 #include "singletons/Settings.hpp"
 #include "singletons/Theme.hpp"
 #include "singletons/WindowManager.hpp"

src/providers/irc/IrcMessageBuilder.hpp

@@ -3,7 +3,6 @@
 #include "common/Aliases.hpp"
 #include "common/Outcome.hpp"
 #include "messages/SharedMessageBuilder.hpp"
-#include "providers/twitch/TwitchBadge.hpp"
 
 #include <IrcMessage>
 #include <QString>
@@ -15,7 +14,6 @@ struct Emote;
 using EmotePtr = std::shared_ptr<const Emote>;
 
 class Channel;
-class TwitchChannel;
 
 class IrcMessageBuilder : public SharedMessageBuilder
 {

src/providers/irc/IrcServer.cpp

@@ -1,5 +1,6 @@
 #include "IrcServer.hpp"
 
+#include "Application.hpp"
 #include "common/QLogging.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageColor.hpp"

src/providers/irc/IrcServer.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "providers/irc/AbstractIrcServer.hpp"
-#include "providers/irc/IrcAccount.hpp"
 
 namespace chatterino {