Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/providers/seventv/SeventvBadges.cpp

@@ -1,6 +1,7 @@
 #include "providers/seventv/SeventvBadges.hpp"
 
 #include "common/NetworkRequest.hpp"
+#include "common/NetworkResult.hpp"
 #include "common/Outcome.hpp"
 #include "messages/Emote.hpp"
 

src/providers/seventv/SeventvBadges.hpp

@@ -1,10 +1,10 @@
 #pragma once
 
 #include "common/Aliases.hpp"
+#include "common/Singleton.hpp"
 #include "util/QStringHash.hpp"
 
 #include <boost/optional.hpp>
-#include <common/Singleton.hpp>
 
 #include <memory>
 #include <shared_mutex>

src/providers/seventv/SeventvEmotes.cpp

@@ -1,12 +1,13 @@
 #include "providers/seventv/SeventvEmotes.hpp"
 
-#include "common/Common.hpp"
 #include "common/NetworkRequest.hpp"
+#include "common/NetworkResult.hpp"
 #include "common/QLogging.hpp"
 #include "messages/Emote.hpp"
 #include "messages/Image.hpp"
 #include "messages/ImageSet.hpp"
 #include "messages/MessageBuilder.hpp"
+#include "providers/seventv/eventapi/SeventvEventAPIDispatch.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
 #include "singletons/Settings.hpp"
 
@@ -14,6 +15,7 @@
 #include <QJsonDocument>
 #include <QThread>
 
+#include <array>
 #include <utility>
 
 /**

src/providers/seventv/SeventvEmotes.hpp

@@ -3,13 +3,17 @@
 #include "boost/optional.hpp"
 #include "common/Aliases.hpp"
 #include "common/Atomic.hpp"
-#include "providers/seventv/eventapi/SeventvEventAPIDispatch.hpp"
-#include "providers/twitch/TwitchChannel.hpp"
+#include "common/FlagsEnum.hpp"
 
 #include <memory>
 
 namespace chatterino {
 
+class Channel;
+struct SeventvEventAPIEmoteAddDispatch;
+struct SeventvEventAPIEmoteUpdateDispatch;
+struct SeventvEventAPIEmoteRemoveDispatch;
+
 // https://github.com/SevenTV/API/blob/a84e884b5590dbb5d91a5c6b3548afabb228f385/data/model/emote-set.model.go#L29-L36
 enum class SeventvActiveEmoteFlag : int64_t {
     None = 0LL,

src/providers/seventv/SeventvEventAPI.cpp

@@ -1,6 +1,7 @@
 #include "providers/seventv/SeventvEventAPI.hpp"
 
 #include "providers/seventv/eventapi/SeventvEventAPIClient.hpp"
+#include "providers/seventv/eventapi/SeventvEventAPIDispatch.hpp"
 #include "providers/seventv/eventapi/SeventvEventAPIMessage.hpp"
 
 #include <QJsonArray>

src/providers/seventv/SeventvEventAPI.hpp

@@ -2,14 +2,19 @@
 
 #include "providers/liveupdates/BasicPubSubClient.hpp"
 #include "providers/liveupdates/BasicPubSubManager.hpp"
-#include "providers/seventv/eventapi/SeventvEventAPIDispatch.hpp"
-#include "providers/seventv/eventapi/SeventvEventAPISubscription.hpp"
 #include "util/QStringHash.hpp"
 
 #include <pajlada/signals/signal.hpp>
 
 namespace chatterino {
 
+struct SeventvEventAPISubscription;
+struct SeventvEventAPIDispatch;
+struct SeventvEventAPIEmoteAddDispatch;
+struct SeventvEventAPIEmoteUpdateDispatch;
+struct SeventvEventAPIEmoteRemoveDispatch;
+struct SeventvEventAPIUserConnectionUpdateDispatch;
+
 class SeventvEventAPI : public BasicPubSubManager<SeventvEventAPISubscription>
 {
     template <typename T>

src/providers/seventv/eventapi/SeventvEventAPIClient.cpp

@@ -1,5 +1,6 @@
 #include "providers/seventv/eventapi/SeventvEventAPIClient.hpp"
 
+#include "providers/seventv/eventapi/SeventvEventAPISubscription.hpp"
 #include "providers/twitch/PubSubHelpers.hpp"
 
 #include <utility>

src/providers/seventv/eventapi/SeventvEventAPIClient.hpp

@@ -1,6 +1,8 @@
 #pragma once
 
 #include "providers/liveupdates/BasicPubSubClient.hpp"
+// this needs to be included for the specialization
+// of std::hash for SeventvEventAPISubscription
 #include "providers/seventv/eventapi/SeventvEventAPISubscription.hpp"
 
 namespace chatterino {

src/providers/seventv/eventapi/SeventvEventAPIMessage.hpp

@@ -1,6 +1,6 @@
 #pragma once
 
-#include "providers/seventv/SeventvEventAPI.hpp"
+#include "providers/seventv/eventapi/SeventvEventAPISubscription.hpp"
 
 #include <boost/optional.hpp>
 #include <magic_enum.hpp>