Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/util/AttachToConsole.cpp

@@ -1,7 +1,9 @@
-#include "AttachToConsole.hpp"
+#include "util/AttachToConsole.hpp"
 
 #ifdef USEWINSDK
 #    include <Windows.h>
+
+#    include <iostream>
 #endif
 
 namespace chatterino {

src/util/NuulsUploader.cpp

@@ -2,11 +2,13 @@
 
 #include "common/Env.hpp"
 #include "common/NetworkRequest.hpp"
+#include "common/NetworkResult.hpp"
 #include "common/QLogging.hpp"
 #include "providers/twitch/TwitchMessageBuilder.hpp"
 #include "singletons/Paths.hpp"
 #include "singletons/Settings.hpp"
 #include "util/CombinePath.hpp"
+#include "widgets/helper/ResizingTextEdit.hpp"
 
 #include <QBuffer>
 #include <QHttpMultiPart>

src/util/NuulsUploader.hpp

@@ -1,10 +1,16 @@
-#include "common/Channel.hpp"
-#include "widgets/helper/ResizingTextEdit.hpp"
+#pragma once
 
 #include <QMimeData>
 #include <QString>
 
+#include <memory>
+
 namespace chatterino {
+
+class ResizingTextEdit;
+class Channel;
+using ChannelPtr = std::shared_ptr<Channel>;
+
 struct RawImageData {
     QByteArray data;
     QString format;
@@ -17,4 +23,5 @@ void upload(RawImageData imageData, ChannelPtr channel,
             ResizingTextEdit &textEdit);
 void upload(const QMimeData *source, ChannelPtr channel,
             ResizingTextEdit &outputTextEdit);
+
 }  // namespace chatterino

src/util/WindowsHelper.cpp

@@ -1,5 +1,7 @@
 #include "WindowsHelper.hpp"
 
+#include <QCoreApplication>
+#include <QFileInfo>
 #include <QSettings>
 
 #ifdef USEWINSDK