Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/widgets/dialogs/ColorPickerDialog.cpp

@@ -2,9 +2,13 @@
 
 #include "providers/colors/ColorProvider.hpp"
 #include "singletons/Theme.hpp"
+#include "util/LayoutCreator.hpp"
+#include "widgets/helper/ColorButton.hpp"
+#include "widgets/helper/QColorPicker.hpp"
 
 #include <QDialogButtonBox>
 #include <QLineEdit>
+#include <QSet>
 
 namespace chatterino {
 

src/widgets/dialogs/ColorPickerDialog.hpp

@@ -1,17 +1,24 @@
 #pragma once
 
-#include "util/LayoutCreator.hpp"
 #include "widgets/BasePopup.hpp"
-#include "widgets/helper/ColorButton.hpp"
-#include "widgets/helper/QColorPicker.hpp"
 
 #include <pajlada/signals/signal.hpp>
 #include <QLabel>
+#include <QLineEdit>
+#include <QRegularExpressionValidator>
 
 #include <array>
 
 namespace chatterino {
 
+class ColorButton;
+class QColorLuminancePicker;
+class QColorPicker;
+class QColSpinBox;
+
+template <class T>
+class LayoutCreator;
+
 /**
  * @brief A custom color picker dialog.
  *

src/widgets/dialogs/EditHotkeyDialog.cpp

@@ -3,6 +3,7 @@
 #include "Application.hpp"
 #include "common/QLogging.hpp"
 #include "controllers/hotkeys/ActionNames.hpp"
+#include "controllers/hotkeys/Hotkey.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
 #include "controllers/hotkeys/HotkeyHelpers.hpp"
 #include "ui_EditHotkeyDialog.h"

src/widgets/dialogs/EditHotkeyDialog.hpp

@@ -1,7 +1,5 @@
 #pragma once
 
-#include "controllers/hotkeys/Hotkey.hpp"
-
 #include <QDialog>
 
 #include <memory>
@@ -14,6 +12,8 @@ class EditHotkeyDialog;
 
 namespace chatterino {
 
+class Hotkey;
+
 class EditHotkeyDialog : public QDialog
 {
     Q_OBJECT

src/widgets/dialogs/EmotePopup.cpp

@@ -9,10 +9,12 @@
 #include "messages/Emote.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageBuilder.hpp"
+#include "messages/MessageElement.hpp"
 #include "providers/twitch/TwitchAccount.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"
 #include "singletons/Emotes.hpp"
+#include "singletons/Settings.hpp"
 #include "singletons/WindowManager.hpp"
 #include "widgets/helper/ChannelView.hpp"
 #include "widgets/helper/TrimRegExpValidator.hpp"

src/widgets/dialogs/EmotePopup.hpp

@@ -1,8 +1,6 @@
 #pragma once
 
-#include "providers/twitch/TwitchChannel.hpp"
 #include "widgets/BasePopup.hpp"
-#include "widgets/Notebook.hpp"
 
 #include <pajlada/signals/signal.hpp>
 #include <QLineEdit>
@@ -13,6 +11,8 @@ struct Link;
 class ChannelView;
 class Channel;
 using ChannelPtr = std::shared_ptr<Channel>;
+class Notebook;
+class TwitchChannel;
 
 class EmotePopup : public BasePopup
 {

src/widgets/dialogs/ReplyThreadPopup.cpp

@@ -3,9 +3,13 @@
 #include "Application.hpp"
 #include "common/Channel.hpp"
 #include "common/QLogging.hpp"
+#include "controllers/accounts/AccountController.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
+#include "messages/Message.hpp"
 #include "messages/MessageThread.hpp"
+#include "providers/twitch/ChannelPointReward.hpp"
 #include "providers/twitch/TwitchAccount.hpp"
+#include "providers/twitch/TwitchChannel.hpp"
 #include "util/LayoutCreator.hpp"
 #include "widgets/helper/ChannelView.hpp"
 #include "widgets/helper/ResizingTextEdit.hpp"

src/widgets/dialogs/SelectChannelDialog.cpp

@@ -4,7 +4,10 @@
 #include "common/QLogging.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
 #include "providers/irc/Irc2.hpp"
+#include "providers/irc/IrcChannel2.hpp"
+#include "providers/irc/IrcServer.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"
+#include "singletons/Settings.hpp"
 #include "singletons/Theme.hpp"
 #include "util/LayoutCreator.hpp"
 #include "widgets/dialogs/IrcConnectionEditor.hpp"

src/widgets/dialogs/SelectChannelDialog.hpp

@@ -1,7 +1,5 @@
 #pragma once
 
-#include "Application.hpp"
-#include "common/Channel.hpp"
 #include "widgets/BaseWindow.hpp"
 
 #include <pajlada/signals/signal.hpp>
@@ -13,6 +11,9 @@ namespace chatterino {
 
 class Notebook;
 class EditableModelView;
+class IndirectChannel;
+class Channel;
+using ChannelPtr = std::shared_ptr<Channel>;
 
 class SelectChannelDialog final : public BaseWindow
 {

src/widgets/dialogs/SelectChannelFiltersDialog.cpp

@@ -1,5 +1,6 @@
 #include "SelectChannelFiltersDialog.hpp"
 
+#include "controllers/filters/FilterRecord.hpp"
 #include "singletons/Settings.hpp"
 
 #include <QCheckBox>

src/widgets/dialogs/SettingsDialog.cpp

@@ -4,9 +4,10 @@
 #include "common/Args.hpp"
 #include "controllers/commands/CommandController.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
-#include "singletons/Resources.hpp"
+#include "singletons/Settings.hpp"
 #include "util/LayoutCreator.hpp"
 #include "widgets/helper/Button.hpp"
+#include "widgets/helper/SettingsDialogTab.hpp"
 #include "widgets/settingspages/AboutPage.hpp"
 #include "widgets/settingspages/AccountsPage.hpp"
 #include "widgets/settingspages/CommandPage.hpp"

src/widgets/dialogs/SettingsDialog.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "widgets/BaseWindow.hpp"
-#include "widgets/helper/SettingsDialogTab.hpp"
 
 #include <pajlada/settings/setting.hpp>
 #include <QFrame>
@@ -19,6 +18,7 @@ namespace chatterino {
 class SettingsPage;
 class SettingsDialogTab;
 class ModerationPage;
+enum class SettingsTabId;
 
 class PageHeader : public QFrame
 {

src/widgets/dialogs/UpdateDialog.hpp

@@ -1,14 +1,16 @@
 #pragma once
 
-#include "pajlada/signals/signalholder.hpp"
 #include "singletons/Updates.hpp"
 #include "widgets/BaseWindow.hpp"
-#include "widgets/Label.hpp"
+
+#include <pajlada/signals/signalholder.hpp>
 
 class QPushButton;
 
 namespace chatterino {
 
+class Label;
+
 class UpdateDialog : public BaseWindow
 {
 public:

src/widgets/dialogs/UserInfoPopup.cpp

@@ -11,6 +11,7 @@
 #include "messages/MessageBuilder.hpp"
 #include "providers/IvrApi.hpp"
 #include "providers/twitch/api/Helix.hpp"
+#include "providers/twitch/ChannelPointReward.hpp"
 #include "providers/twitch/TwitchAccount.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"
@@ -21,7 +22,6 @@
 #include "util/Clipboard.hpp"
 #include "util/Helpers.hpp"
 #include "util/LayoutCreator.hpp"
-#include "util/PostToThread.hpp"
 #include "util/StreamerMode.hpp"
 #include "widgets/helper/ChannelView.hpp"
 #include "widgets/helper/EffectLabel.hpp"

src/widgets/dialogs/UserInfoPopup.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "widgets/DraggablePopup.hpp"
-#include "widgets/helper/ChannelView.hpp"
 
 #include <pajlada/signals/scoped-connection.hpp>
 #include <pajlada/signals/signal.hpp>
@@ -15,6 +14,8 @@ namespace chatterino {
 class Channel;
 using ChannelPtr = std::shared_ptr<Channel>;
 class Label;
+class ChannelView;
+class Split;
 
 class UserInfoPopup final : public DraggablePopup
 {

src/widgets/dialogs/switcher/SwitchSplitItem.cpp

@@ -3,7 +3,9 @@
 #include "Application.hpp"
 #include "singletons/Fonts.hpp"
 #include "singletons/Theme.hpp"
+#include "singletons/WindowManager.hpp"
 #include "widgets/helper/NotebookTab.hpp"
+#include "widgets/splits/Split.hpp"
 
 namespace chatterino {
 

src/widgets/dialogs/switcher/SwitchSplitItem.hpp

@@ -1,14 +1,16 @@
 #pragma once
 
-#include "singletons/WindowManager.hpp"
 #include "widgets/dialogs/switcher/AbstractSwitcherItem.hpp"
-#include "widgets/helper/NotebookTab.hpp"
-#include "widgets/Notebook.hpp"
-#include "widgets/splits/Split.hpp"
-#include "widgets/Window.hpp"
+
+#include <QPainter>
+#include <QRect>
+#include <QSize>
 
 namespace chatterino {
 
+class SplitContainer;
+class Split;
+
 class SwitchSplitItem : public AbstractSwitcherItem
 {
 public: