Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/widgets/helper/ChannelView.cpp

@@ -4,15 +4,19 @@
 #include "common/Common.hpp"
 #include "common/QLogging.hpp"
 #include "controllers/accounts/AccountController.hpp"
+#include "controllers/commands/Command.hpp"
 #include "controllers/commands/CommandController.hpp"
+#include "controllers/filters/FilterSet.hpp"
 #include "debug/Benchmark.hpp"
 #include "messages/Emote.hpp"
+#include "messages/Image.hpp"
 #include "messages/layouts/MessageLayout.hpp"
 #include "messages/layouts/MessageLayoutElement.hpp"
 #include "messages/LimitedQueueSnapshot.hpp"
 #include "messages/Message.hpp"
 #include "messages/MessageBuilder.hpp"
 #include "messages/MessageElement.hpp"
+#include "messages/MessageThread.hpp"
 #include "providers/LinkResolver.hpp"
 #include "providers/twitch/TwitchAccount.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
@@ -31,6 +35,7 @@
 #include "widgets/dialogs/SettingsDialog.hpp"
 #include "widgets/dialogs/UserInfoPopup.hpp"
 #include "widgets/helper/EffectLabel.hpp"
+#include "widgets/helper/ScrollbarHighlight.hpp"
 #include "widgets/helper/SearchPopup.hpp"
 #include "widgets/Scrollbar.hpp"
 #include "widgets/splits/Split.hpp"

src/widgets/helper/ChannelView.hpp

@@ -1,8 +1,6 @@
 #pragma once
 
 #include "common/FlagsEnum.hpp"
-#include "controllers/filters/FilterSet.hpp"
-#include "messages/Image.hpp"
 #include "messages/LimitedQueue.hpp"
 #include "messages/LimitedQueueSnapshot.hpp"
 #include "messages/Selection.hpp"
@@ -10,6 +8,7 @@
 #include "widgets/BaseWidget.hpp"
 
 #include <pajlada/signals/signal.hpp>
+#include <QMenu>
 #include <QPaintEvent>
 #include <QScroller>
 #include <QTimer>
@@ -43,6 +42,8 @@ class EffectLabel;
 struct Link;
 class MessageLayoutElement;
 class Split;
+class FilterSet;
+using FilterSetPtr = std::shared_ptr<FilterSet>;
 
 enum class PauseReason {
     Mouse,

src/widgets/helper/EffectLabel.hpp

@@ -1,6 +1,5 @@
 #pragma once
 
-#include "widgets/BaseWidget.hpp"
 #include "widgets/helper/Button.hpp"
 #include "widgets/helper/SignalLabel.hpp"
 #include "widgets/Label.hpp"

src/widgets/helper/NotebookTab.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include "common/Common.hpp"
-#include "widgets/BaseWidget.hpp"
 #include "widgets/helper/Button.hpp"
 #include "widgets/Notebook.hpp"
 
@@ -14,8 +13,6 @@ namespace chatterino {
 
 #define NOTEBOOK_TAB_HEIGHT 28
 
-// class Notebook;
-class Notebook;
 class SplitContainer;
 
 class NotebookTab : public Button

src/widgets/helper/SearchPopup.cpp

@@ -1,7 +1,10 @@
 #include "SearchPopup.hpp"
 
+#include "Application.hpp"
 #include "common/Channel.hpp"
+#include "controllers/filters/FilterSet.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
+#include "messages/MessageElement.hpp"
 #include "messages/search/AuthorPredicate.hpp"
 #include "messages/search/BadgePredicate.hpp"
 #include "messages/search/ChannelPredicate.hpp"
@@ -12,6 +15,7 @@
 #include "messages/search/SubtierPredicate.hpp"
 #include "singletons/WindowManager.hpp"
 #include "widgets/helper/ChannelView.hpp"
+#include "widgets/splits/Split.hpp"
 
 #include <QHBoxLayout>
 #include <QLineEdit>

src/widgets/helper/SearchPopup.hpp

@@ -1,11 +1,8 @@
 #pragma once
 
-#include "controllers/filters/FilterSet.hpp"
 #include "ForwardDecl.hpp"
 #include "messages/LimitedQueueSnapshot.hpp"
-#include "messages/search/MessagePredicate.hpp"
 #include "widgets/BasePopup.hpp"
-#include "widgets/splits/Split.hpp"
 
 #include <memory>
 
@@ -13,6 +10,9 @@ class QLineEdit;
 
 namespace chatterino {
 
+class Split;
+class MessagePredicate;
+
 class SearchPopup : public BasePopup
 {
 public:

src/widgets/helper/SettingsDialogTab.hpp

@@ -13,7 +13,7 @@ namespace chatterino {
 class SettingsPage;
 class SettingsDialog;
 
-enum SettingsTabId {
+enum class SettingsTabId {
     None,
     Accounts,
     Moderation,