Remove Unnecessary Includes in Headers (#4275)

* refactor: remove unnecessary includes in headers

* fix: formatting

* chore: changelog

* fix: scrollbar

* fix: suggestions and old appbase remains

* fix: suggestion

* fix: missing Qt forward declarations

* fix: another qt include

* fix: includes for precompiled-headers=off

* Add missing `<memory>` includes

* Add missing `#pragma once`

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>

src/widgets/splits/ClosedSplits.hpp

@@ -1,8 +1,6 @@
 #pragma once
 
-#include "common/Channel.hpp"
-#include "widgets/helper/NotebookTab.hpp"
-
+#include <QList>
 #include <QUuid>
 
 #include <deque>
@@ -11,6 +9,8 @@
 
 namespace chatterino {
 
+class NotebookTab;
+
 class ClosedSplits
 {
 public:

src/widgets/splits/InputCompletionItem.cpp

@@ -1,4 +1,7 @@
-#include "InputCompletionItem.hpp"
+#include "widgets/splits/InputCompletionItem.hpp"
+
+#include "messages/Emote.hpp"
+#include "messages/Image.hpp"
 
 namespace chatterino {
 

src/widgets/splits/InputCompletionItem.hpp

@@ -1,12 +1,14 @@
 #pragma once
 
-#include "messages/Emote.hpp"
 #include "widgets/listview/GenericListItem.hpp"
 
 #include <functional>
 
 namespace chatterino {
 
+struct Emote;
+using EmotePtr = std::shared_ptr<const Emote>;
+
 class InputCompletionItem : public GenericListItem
 {
     using ActionCallback = std::function<void(const QString &)>;

src/widgets/splits/InputCompletionPopup.hpp

@@ -1,6 +1,5 @@
 #pragma once
 
-#include "common/Channel.hpp"
 #include "widgets/BasePopup.hpp"
 #include "widgets/listview/GenericListModel.hpp"
 
@@ -8,6 +7,9 @@
 
 namespace chatterino {
 
+class Channel;
+using ChannelPtr = std::shared_ptr<Channel>;
+
 class GenericListView;
 
 class InputCompletionPopup : public BasePopup

src/widgets/splits/Split.cpp

@@ -2,15 +2,14 @@
 
 #include "Application.hpp"
 #include "common/Common.hpp"
-#include "common/Env.hpp"
 #include "common/NetworkRequest.hpp"
+#include "common/NetworkResult.hpp"
 #include "common/QLogging.hpp"
 #include "controllers/accounts/AccountController.hpp"
 #include "controllers/commands/CommandController.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
 #include "controllers/notifications/NotificationController.hpp"
 #include "messages/MessageThread.hpp"
-#include "providers/twitch/EmoteValue.hpp"
 #include "providers/twitch/TwitchAccount.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"

src/widgets/splits/Split.hpp

@@ -3,10 +3,10 @@
 #include "common/Aliases.hpp"
 #include "common/Channel.hpp"
 #include "common/NullablePtr.hpp"
-#include "pajlada/signals/signalholder.hpp"
 #include "widgets/BaseWidget.hpp"
 
 #include <boost/signals2.hpp>
+#include <pajlada/signals/signalholder.hpp>
 #include <QFont>
 #include <QShortcut>
 #include <QVBoxLayout>

src/widgets/splits/SplitContainer.cpp

@@ -3,6 +3,7 @@
 #include "Application.hpp"
 #include "common/Common.hpp"
 #include "common/QLogging.hpp"
+#include "common/WindowDescriptors.hpp"
 #include "debug/AssertInGuiThread.hpp"
 #include "singletons/Fonts.hpp"
 #include "singletons/Theme.hpp"
@@ -15,7 +16,6 @@
 #include "widgets/splits/Split.hpp"
 #include "widgets/Window.hpp"
 
-#include <boost/foreach.hpp>
 #include <QApplication>
 #include <QJsonArray>
 #include <QJsonObject>

src/widgets/splits/SplitContainer.hpp

@@ -12,6 +12,7 @@
 #include <algorithm>
 #include <optional>
 #include <unordered_map>
+#include <variant>
 #include <vector>
 
 class QJsonObject;

src/widgets/splits/SplitHeader.cpp

@@ -1,6 +1,9 @@
 #include "widgets/splits/SplitHeader.hpp"
 
 #include "Application.hpp"
+#include "common/NetworkCommon.hpp"
+#include "common/NetworkRequest.hpp"
+#include "common/NetworkResult.hpp"
 #include "controllers/accounts/AccountController.hpp"
 #include "controllers/commands/CommandController.hpp"
 #include "controllers/hotkeys/Hotkey.hpp"
@@ -15,7 +18,6 @@
 #include "singletons/Theme.hpp"
 #include "singletons/WindowManager.hpp"
 #include "util/Helpers.hpp"
-#include "util/LayoutCreator.hpp"
 #include "util/LayoutHelper.hpp"
 #include "util/StreamerMode.hpp"
 #include "widgets/dialogs/SettingsDialog.hpp"

src/widgets/splits/SplitInput.cpp

@@ -5,6 +5,8 @@
 #include "controllers/commands/CommandController.hpp"
 #include "controllers/hotkeys/HotkeyController.hpp"
 #include "messages/Link.hpp"
+#include "messages/Message.hpp"
+#include "messages/MessageThread.hpp"
 #include "providers/twitch/TwitchChannel.hpp"
 #include "providers/twitch/TwitchCommon.hpp"
 #include "providers/twitch/TwitchIrcServer.hpp"
@@ -22,7 +24,6 @@
 #include "widgets/splits/InputCompletionPopup.hpp"
 #include "widgets/splits/Split.hpp"
 #include "widgets/splits/SplitContainer.hpp"
-#include "widgets/splits/SplitInput.hpp"
 
 #include <QCompleter>
 #include <QPainter>

src/widgets/splits/SplitInput.hpp

@@ -2,7 +2,6 @@
 
 #include "util/QObjectRef.hpp"
 #include "widgets/BaseWidget.hpp"
-#include "widgets/dialogs/EmotePopup.hpp"
 
 #include <QHBoxLayout>
 #include <QLabel>

src/widgets/splits/SplitOverlay.hpp

@@ -1,8 +1,8 @@
 #pragma once
 
-#include "pajlada/signals/signalholder.hpp"
 #include "widgets/BaseWidget.hpp"
 
+#include <pajlada/signals/signalholder.hpp>
 #include <QGridLayout>
 #include <QPushButton>