From 14776deb35979780297ce9ad24d03db45a724c90 Mon Sep 17 00:00:00 2001 From: pajlada Date: Sat, 30 Nov 2024 14:14:11 +0100 Subject: [PATCH] fix: remove cosmetic allowCommandsAtEnd setting (#5745) Any new functionality we'd want to add here would probably not be what people who checked this setting actually wanted it do be. It's best to start fresh if we want to add similar functionality. --- CHANGELOG.md | 1 + src/singletons/Settings.hpp | 3 --- src/widgets/settingspages/CommandPage.cpp | 4 ---- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3aacff6a..4c0b0f21 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -85,6 +85,7 @@ - Dev: Update vcpkg build Qt from 6.5.0 to 6.7.0, boost from 1.83.0 to 1.85.0, openssl from 3.1.3 to 3.3.0. (#5422) - Dev: Unsingletonize `ISoundController`. (#5462) - Dev: Use Qt's high DPI scaling. (#4868, #5400) +- Dev: Removed cosmetic "Also match the trigger at the end of the message" setting. (#5745) - Dev: Add doxygen build target. (#5377) - Dev: Make printing of strings in tests easier. (#5379) - Dev: Refactor and document `Scrollbar`. (#5334, #5393) diff --git a/src/singletons/Settings.hpp b/src/singletons/Settings.hpp index c262dd23..e996a832 100644 --- a/src/singletons/Settings.hpp +++ b/src/singletons/Settings.hpp @@ -295,9 +295,6 @@ public: BoolSetting mentionUsersWithComma = {"/behaviour/mentionUsersWithComma", true}; - /// Commands - BoolSetting allowCommandsAtEnd = {"/commands/allowCommandsAtEnd", false}; - /// Emotes BoolSetting scaleEmotesByLineHeight = {"/emotes/scaleEmotesByLineHeight", false}; diff --git a/src/widgets/settingspages/CommandPage.cpp b/src/widgets/settingspages/CommandPage.cpp index 3b1409f2..833ba713 100644 --- a/src/widgets/settingspages/CommandPage.cpp +++ b/src/widgets/settingspages/CommandPage.cpp @@ -123,10 +123,6 @@ CommandPage::CommandPage() }); } - layout.append( - this->createCheckBox("Also match the trigger at the end of the message", - getSettings()->allowCommandsAtEnd)); - QLabel *text = layout.emplace(HELP_TEXT).getElement(); text->setWordWrap(true); text->setStyleSheet("color: #bbb");