chatterino2
Code Issues

refactor: rename Badge to TwitchBadge (#6706)

Browse Source 
this change is made to clarify that the previously-called Badge object
is actually specialized for Twitch badges
This commit is contained in:
pajlada
2026-01-04 12:52:02 +01:00
committed by GitHub
parent 7fed720d18
commit 18e3d7c72b
190 changed files with 1058 additions and 1049 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/HighlightController.cpp
+1 -1
View File
@@ -166,7 +166,7 @@ struct TestCase {
// TODO: create one of these from a raw irc message? hmm xD
struct {
MessageParseArgs args;
std::vector<Badge> badges;
std::vector<TwitchBadge> badges;
QString senderName;
QString originalMessage;
MessageFlags flags;
tests/src/TwitchIrc.cpp
+12 -12
View File
@@ -90,7 +90,7 @@ TEST(TwitchIrc, BadgeInfoParsing)
struct TestCase {
QByteArray input;
std::unordered_map<QString, QString> expectedBadgeInfo;
std::vector<Badge> expectedBadges;
std::vector<TwitchBadge> expectedBadges;
};
std::vector<TestCase> testCases{
@@ -100,7 +100,7 @@ TEST(TwitchIrc, BadgeInfoParsing)
{"predictions", R"(<<<<<<\sHEAD[15A⸝asdf/test)"},
},
{
Badge{"predictions", "pink-2"},
TwitchBadge{"predictions", "pink-2"},
},
},
{
@@ -110,10 +110,10 @@ TEST(TwitchIrc, BadgeInfoParsing)
{"founder", "17"},
},
{
Badge{"predictions", "pink-2"},
Badge{"vip", "1"},
Badge{"founder", "0"},
Badge{"bits", "1"},
TwitchBadge{"predictions", "pink-2"},
TwitchBadge{"vip", "1"},
TwitchBadge{"founder", "0"},
TwitchBadge{"bits", "1"},
},
},
{
@@ -122,9 +122,9 @@ TEST(TwitchIrc, BadgeInfoParsing)
{"predictions", "foo/bar/baz"},
},
{
Badge{"predictions", "blue-1"},
Badge{"moderator", "1"},
Badge{"glhf-pledge", "1"},
TwitchBadge{"predictions", "blue-1"},
TwitchBadge{"moderator", "1"},
TwitchBadge{"glhf-pledge", "1"},
},
},
{
@@ -133,9 +133,9 @@ TEST(TwitchIrc, BadgeInfoParsing)
{"subscriber", "22"},
},
{
Badge{"broadcaster", "1"},
Badge{"subscriber", "18"},
Badge{"glhf-pledge", "1"},
TwitchBadge{"broadcaster", "1"},
TwitchBadge{"subscriber", "18"},
TwitchBadge{"glhf-pledge", "1"},
},
},
};