chatterino2
Code Issues

Make tests more platform agnostic (#4650)

Browse Source 
Use QTemporaryDir to create the test directory
Add option to use httpbin over local docker
Increase delay for opening a connection

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
This commit is contained in:
nerix
2023-05-26 14:54:23 +02:00
committed by GitHub
parent 2264c44f10
commit 1bc423d9c4
8 changed files with 56 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/HighlightController.cpp
+8 -4
View File
@@ -19,6 +19,7 @@
#include <QDir>
#include <QFile>
#include <QString>
#include <QTemporaryDir>
using namespace chatterino;
using ::testing::Exactly;
@@ -178,9 +179,9 @@ protected:
void SetUp() override
{
// Write default settings to the mock settings json file
ASSERT_TRUE(QDir().mkpath("/tmp/c2-tests"));
this->settingsDir_ = std::make_unique<QTemporaryDir>();
QFile settingsFile("/tmp/c2-tests/settings.json");
QFile settingsFile(this->settingsDir_->filePath("settings.json"));
ASSERT_TRUE(settingsFile.open(QIODevice::WriteOnly | QIODevice::Text));
ASSERT_GT(settingsFile.write(DEFAULT_SETTINGS.toUtf8()), 0);
ASSERT_TRUE(settingsFile.flush());
@@ -194,7 +195,7 @@ protected:
EXPECT_CALL(*this->mockHelix, update).Times(Exactly(1));
this->mockApplication = std::make_unique<MockApplication>();
this->settings = std::make_unique<Settings>("/tmp/c2-tests");
this->settings = std::make_unique<Settings>(this->settingsDir_->path());
this->paths = std::make_unique<Paths>();
this->controller = std::make_unique<HighlightController>();
@@ -206,16 +207,19 @@ protected:
void TearDown() override
{
ASSERT_TRUE(QDir("/tmp/c2-tests").removeRecursively());
this->mockApplication.reset();
this->settings.reset();
this->paths.reset();
this->controller.reset();
this->settingsDir_.reset();
delete this->mockHelix;
}
std::unique_ptr<QTemporaryDir> settingsDir_;
std::unique_ptr<MockApplication> mockApplication;
std::unique_ptr<Settings> settings;
std::unique_ptr<Paths> paths;