chatterino2
Code Issues

Fix crash when moving splits across windows and closing parent tab (#2259)

Browse Source
This commit is contained in:
pajlada
2020-12-06 15:34:40 +01:00
committed by GitHub
parent bf4c9cebb1
commit 277ef4b2e3
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1
View File
@@ -53,6 +53,7 @@
- Bugfix: Fix a bug that caused `Ignore page` to fall into an infinity loop with an empty pattern and regex enabled (#2125) - Bugfix: Fix a bug that caused `Ignore page` to fall into an infinity loop with an empty pattern and regex enabled (#2125)
- Bugfix: Fix a crash caused by FrankerFaceZ responding with invalid emote links (#2191) - Bugfix: Fix a crash caused by FrankerFaceZ responding with invalid emote links (#2191)
- Bugfix: Fix a freeze caused by ignored & replaced phrases followed by Twitch Emotes (#2231) - Bugfix: Fix a freeze caused by ignored & replaced phrases followed by Twitch Emotes (#2231)
- Bugfix: Fix a crash bug that occurred when moving splits across windows and closing the "parent tab" (#2249, #2259)
- Dev: Updated minimum required Qt framework version to 5.12. (#2210) - Dev: Updated minimum required Qt framework version to 5.12. (#2210)
## 2.2.2 ## 2.2.2
src/widgets/splits/SplitContainer.cpp
+9 -9
View File
@@ -211,19 +211,19 @@ void SplitContainer::addSplit(Split *split)
this->refreshTab(); this->refreshTab();
split->getChannelView().tabHighlightRequested.connect( this->managedConnect(split->getChannelView().tabHighlightRequested,
[this](HighlightState state) { [this](HighlightState state) {
if (this->tab_ != nullptr) if (this->tab_ != nullptr)
{ {
this->tab_->setHighlightState(state); this->tab_->setHighlightState(state);
} }
}); });
split->getChannelView().liveStatusChanged.connect([this]() { this->managedConnect(split->getChannelView().liveStatusChanged, [this]() {
this->refreshTabLiveStatus(); this->refreshTabLiveStatus();
}); });
split->focused.connect([this, split] { this->managedConnect(split->focused, [this, split] {
this->setSelected(split); this->setSelected(split);
}); });