Fix crash that could occur when closing down splits (#4277)

* Fix crash that could occur when closing down splits

Specifically, if a split was closed after the request for a thumbnail
had been made, but before the request had finished, we'd run into a
use-after-free issue

* Add changelog entry
This commit is contained in:
pajlada
2022-12-31 13:39:28 +01:00
committed by GitHub
parent 5fc170ba4b
commit 293aa370c5
2 changed files with 2 additions and 0 deletions
+1
View File
@@ -804,6 +804,7 @@ void SplitHeader::updateChannelText()
this->lastThumbnail_.elapsed() > THUMBNAIL_MAX_AGE_MS))
{
NetworkRequest(url, NetworkRequestType::Get)
.caller(this)
.onSuccess([this](auto result) -> Outcome {
// NOTE: We do not follow the redirects, so we need to make sure we only treat code 200 as a valid image
if (result.status() == 200)