fix: correctly load twitch badges in highlights page (#5223)

This commit is contained in:
pajlada
2024-03-02 12:05:12 +01:00
committed by GitHub
parent c1fa51242f
commit 3928cc9578
2 changed files with 10 additions and 7 deletions
+9 -7
View File
@@ -242,10 +242,11 @@ void TwitchBadges::getBadgeIcons(const QList<DisplayBadge> &badges,
void TwitchBadges::loadEmoteImage(const QString &name, ImagePtr image,
BadgeIconCallback &&callback)
{
NetworkRequest(image->url().string)
auto url = image->url().string;
NetworkRequest(url)
.concurrent()
.cache()
.onSuccess([this, name, callback](auto result) {
.onSuccess([this, name, callback, url](auto result) {
auto data = result.getData();
// const cast since we are only reading from it
@@ -255,17 +256,18 @@ void TwitchBadges::loadEmoteImage(const QString &name, ImagePtr image,
if (!reader.canRead() || reader.size().isEmpty())
{
qCWarning(chatterinoTwitch)
<< "Can't read badge image at" << url << "for" << name
<< reader.errorString();
return;
}
QImage image = reader.read();
if (image.isNull())
{
return;
}
if (reader.imageCount() <= 0)
{
qCWarning(chatterinoTwitch)
<< "Failed reading badge image at" << url << "for" << name
<< reader.errorString();
return;
}