chatterino2
Code Issues

chore: ensure statics are only present once in the final app (#5588)

Browse Source
This commit is contained in:
nerix
2024-09-14 14:13:12 +02:00
committed by GitHub
parent 2d8937f43e
commit 3d06f8612f
14 changed files with 177 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/dialogs/ChannelFilterEditorDialog.cpp
+3 -3
View File
@@ -100,7 +100,7 @@ ChannelFilterEditorDialog::ValueSpecifier::ValueSpecifier()
this->typeCombo_->insertItems(
0, {"Constant Text", "Constant Number", "Variable"});
this->varCombo_->insertItems(0, filters::validIdentifiersMap.values());
this->varCombo_->insertItems(0, filters::VALID_IDENTIFIERS_MAP.values());
this->layout_->addWidget(this->typeCombo_);
this->layout_->addWidget(this->varCombo_, 1);
@@ -142,7 +142,7 @@ void ChannelFilterEditorDialog::ValueSpecifier::setValue(const QString &value)
if (this->typeCombo_->currentIndex() == 2)
{
this->varCombo_->setCurrentText(
filters::validIdentifiersMap.value(value));
filters::VALID_IDENTIFIERS_MAP.value(value));
}
else
{
@@ -165,7 +165,7 @@ QString ChannelFilterEditorDialog::ValueSpecifier::expressionText()
case 1: // number
return this->valueInput_->text();
case 2: // variable
return filters::validIdentifiersMap.key(
return filters::VALID_IDENTIFIERS_MAP.key(
this->varCombo_->currentText());
default:
return "";
src/widgets/helper/NotebookTab.hpp
+1 -1
View File
@@ -11,7 +11,7 @@
namespace chatterino {
constexpr int NOTEBOOK_TAB_HEIGHT = 28;
inline constexpr int NOTEBOOK_TAB_HEIGHT = 28;
class SplitContainer;