From 41acd4e9718d3b016d120bdc573f96d83e1a8c38 Mon Sep 17 00:00:00 2001 From: pajlada Date: Fri, 21 Mar 2025 23:27:49 +0100 Subject: [PATCH] fix: disable precompiled headers for macOS (#6104) --- CHANGELOG.md | 1 + CMakeLists.txt | 2 +- src/CMakeLists.txt | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 612781e1..6ac5b34c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ - Bugfix: Fixed the channel name input not being focused when opening the select-channel dialog. (#6096) - Bugfix: Fixed inputs in dialogs not having a border around and padding in them. (#6098) +- Dev: Temporarily disable precompiled header support for macOS. (#6104) ## 2.5.3-beta.1 diff --git a/CMakeLists.txt b/CMakeLists.txt index dee5a81f..e00856bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -20,7 +20,7 @@ option(USE_SYSTEM_QTKEYCHAIN "Use system QtKeychain library" OFF) option(BUILD_WITH_QTKEYCHAIN "Build Chatterino with support for your system key chain" ON) option(USE_SYSTEM_MINIAUDIO "Build Chatterino with your system miniaudio" OFF) option(BUILD_WITH_CRASHPAD "Build chatterino with crashpad" OFF) -option(USE_PRECOMPILED_HEADERS "Use precompiled headers" ON) +option(USE_PRECOMPILED_HEADERS "Use precompiled headers (Temporarily not supported on macOS)" ON) option(BUILD_WITH_QT6 "Build with Qt6" On) option(BUILD_WITH_LIBNOTIFY "Build with libnotify" ON) option(CHATTERINO_GENERATE_COVERAGE "Generate coverage files" OFF) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 36242321..71bc6dae 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -982,7 +982,7 @@ if (BUILD_APP) endif() endif () -if (USE_PRECOMPILED_HEADERS) +if (USE_PRECOMPILED_HEADERS AND NOT APPLE) message(STATUS "Building with precompiled headers") target_precompile_headers(${LIBRARY_PROJECT} PRIVATE PrecompiledHeader.hpp) else ()