feat: add SettingWidget::dropdown support for int style enums (#6303)

This commit is contained in:
pajlada
2025-06-28 14:31:11 +02:00
committed by GitHub
parent f3c11a5159
commit 42fb5ad077
10 changed files with 163 additions and 65 deletions
+80 -1
View File
@@ -1,6 +1,8 @@
#include "widgets/settingspages/SettingWidget.hpp"
#include "singletons/Settings.hpp"
#include "common/QLogging.hpp"
#include "singletons/Settings.hpp" // IWYU pragma: keep
#include "util/QMagicEnumTagged.hpp"
#include "util/RapidJsonSerializeQString.hpp" // IWYU pragma: keep
#include "widgets/dialogs/ColorPickerDialog.hpp"
#include "widgets/helper/color/ColorButton.hpp"
@@ -230,6 +232,83 @@ template SettingWidget *SettingWidget::dropdown<ShowModerationState>(
template SettingWidget *SettingWidget::dropdown<EmojiStyle>(
const QString &label, EnumStringSetting<EmojiStyle> &setting);
template <typename T>
SettingWidget *SettingWidget::dropdown(const QString &label,
EnumSetting<T> &setting)
{
auto *widget = new SettingWidget(label);
auto *lbl = new QLabel(label % ":");
auto *combo = new ComboBox;
combo->setFocusPolicy(Qt::StrongFocus);
for (const auto value : magic_enum::enum_values<T>())
{
combo->addItem(qmagicenum::enumDisplayNameString(value),
QVariant(static_cast<std::underlying_type_t<T>>(value)));
}
// TODO: this can probably use some other size hint/size strategy
combo->setMinimumWidth(combo->minimumSizeHint().width());
widget->actionWidget = combo;
widget->label = lbl;
widget->hLayout->addWidget(lbl);
widget->hLayout->addStretch(1);
widget->hLayout->addWidget(combo);
setting.connect(
[combo, label](const auto &value) {
std::optional<int> foundRow;
for (auto row = 0; row < combo->model()->rowCount(); ++row)
{
auto index = combo->model()->index(row, 0);
auto rowEnumValue = index.data(Qt::UserRole);
if (rowEnumValue == value)
{
foundRow = row;
break;
}
}
if (foundRow)
{
combo->setCurrentIndex(*foundRow);
}
else
{
qCWarning(chatterinoWidget)
<< "Did not find a correct combo box row for" << label
<< " with value" << value;
}
},
widget->managedConnections);
QObject::connect(combo, &QComboBox::currentTextChanged,
[label, combo, &setting](const auto &newText) {
bool ok = true;
auto enumValue = combo->currentData().toInt(&ok);
if (!ok)
{
qCWarning(chatterinoWidget)
<< "Combo" << label << " with value" << newText
<< "did not contain an intable UserRole data";
return;
}
setting.setValue(enumValue);
});
return widget;
}
template SettingWidget *SettingWidget::dropdown<LastMessageLineStyle>(
const QString &label, EnumSetting<LastMessageLineStyle> &setting);
template SettingWidget *SettingWidget::dropdown<ThumbnailPreviewMode>(
const QString &label, EnumSetting<ThumbnailPreviewMode> &setting);
SettingWidget *SettingWidget::colorButton(const QString &label,
QStringSetting &setting)
{