chatterino2
Code Issues

refactor: clean up toStdString usages in tests (#5346)

Browse Source 
* tests: Add QString/QStringView << operators for std::ostream

This makes it easier to print QString/QStringView's in ASSERT_EQ outputs

* tests: clean up toStdString usages

* fix: use QByteArray.toStdString instead
This commit is contained in:
pajlada
2024-04-21 22:52:44 +02:00
committed by GitHub
parent dfa929e207
commit 4a1ce2a3b3
5 changed files with 47 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/LinkParser.cpp
+8 -6
View File
@@ -1,5 +1,7 @@
#include "common/LinkParser.hpp"
#include "TestHelpers.hpp"
#include <gtest/gtest.h>
#include <QString>
#include <QStringList>
@@ -15,13 +17,13 @@ struct Case {
{
auto input = this->protocol + this->host + this->rest;
LinkParser p(input);
ASSERT_TRUE(p.result().has_value()) << input.toStdString();
ASSERT_TRUE(p.result().has_value()) << input;
const auto &r = *p.result();
ASSERT_EQ(r.source, input);
ASSERT_EQ(r.protocol, this->protocol) << this->protocol.toStdString();
ASSERT_EQ(r.host, this->host) << this->host.toStdString();
ASSERT_EQ(r.rest, this->rest) << this->rest.toStdString();
ASSERT_EQ(r.protocol, this->protocol) << this->protocol;
ASSERT_EQ(r.host, this->host) << this->host;
ASSERT_EQ(r.rest, this->rest) << this->rest;
}
};
@@ -126,7 +128,7 @@ TEST(LinkParser, doesntParseInvalidIpv4Links)
for (const auto &input : inputs)
{
LinkParser p(input);
ASSERT_FALSE(p.result().has_value()) << input.toStdString();
ASSERT_FALSE(p.result().has_value()) << input;
}
}
@@ -170,6 +172,6 @@ TEST(LinkParser, doesntParseInvalidLinks)
for (const auto &input : inputs)
{
LinkParser p(input);
ASSERT_FALSE(p.result().has_value()) << input.toStdString();
ASSERT_FALSE(p.result().has_value()) << input;
}
}