Define Git and date constants in executables only (#4681)

src/common/Version.cpp

@@ -4,27 +4,14 @@
 
 #include <QFileInfo>
 
-#define UGLYMACROHACK1(s) #s
-#define FROM_EXTERNAL_DEFINE(s) UGLYMACROHACK1(s)
-
 namespace chatterino {
 
 Version::Version()
+    : version_(CHATTERINO_VERSION)
+    , commitHash_(QStringLiteral(CHATTERINO_GIT_HASH))
+    , isModified_(CHATTERINO_GIT_MODIFIED == 1)
+    , dateOfBuild_(QStringLiteral(CHATTERINO_CMAKE_GEN_DATE))
 {
-    this->version_ = CHATTERINO_VERSION;
-
-    this->commitHash_ =
-        QString(FROM_EXTERNAL_DEFINE(CHATTERINO_GIT_HASH)).remove('"');
-
-#ifdef CHATTERINO_GIT_MODIFIED
-    this->isModified_ = true;
-#endif
-
-#ifdef CHATTERINO_CMAKE_GEN_DATE
-    this->dateOfBuild_ =
-        QString(FROM_EXTERNAL_DEFINE(CHATTERINO_CMAKE_GEN_DATE)).remove('"');
-#endif
-
     this->fullVersion_ = "Chatterino ";
     if (Modes::instance().isNightly)
     {