From 4d9ea37ff46bfb80988c9b549b01c54f4687c9ca Mon Sep 17 00:00:00 2001 From: nerix Date: Wed, 2 Oct 2024 18:33:36 +0200 Subject: [PATCH] fix: use correct selection index when double-clicking into the void (#5617) --- CHANGELOG.md | 1 + src/widgets/helper/ChannelView.cpp | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0755efc9..ba3c188b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,7 @@ - Bugfix: Fixed log files being locked longer than needed. (#5592) - Bugfix: Fixed global badges not showing in anonymous mode. (#5599) - Bugfix: Fixed grammar in the user highlight page. (#5602) +- Bugfix: Fixed double-click selection not working when clicking outside a message. (#5617) - Dev: Update Windows build from Qt 6.5.0 to Qt 6.7.1. (#5420) - Dev: Update vcpkg build Qt from 6.5.0 to 6.7.0, boost from 1.83.0 to 1.85.0, openssl from 3.1.3 to 3.3.0. (#5422) - Dev: Unsingletonize `ISoundController`. (#5462) diff --git a/src/widgets/helper/ChannelView.cpp b/src/widgets/helper/ChannelView.cpp index 026af4c1..93be6ad9 100644 --- a/src/widgets/helper/ChannelView.cpp +++ b/src/widgets/helper/ChannelView.cpp @@ -2707,6 +2707,10 @@ void ChannelView::mouseDoubleClickEvent(QMouseEvent *event) if (hoverLayoutElement == nullptr) { + // XXX: this is duplicate work + auto idx = layout->getSelectionIndex(relativePos); + SelectionItem item(messageIndex, idx); + this->doubleClickSelection_ = {item, item}; return; }