From 518262596abc941070ddee4724bb4d2265aa822a Mon Sep 17 00:00:00 2001 From: Felanbird <41973452+Felanbird@users.noreply.github.com> Date: Mon, 21 Nov 2022 12:58:32 -0500 Subject: [PATCH] Fix issue with VIPs who have Asian Language display names (#4174) Co-authored-by: Rasmus Karlsson --- CHANGELOG.md | 4 +++- src/controllers/commands/CommandController.cpp | 11 ++--------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dcf8dc31..fbe436bb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,9 @@ ## Unversioned -## 2.4.0 +- Bugfix: Fixed being unable to see the usercard of VIPs who have Asian language display names. (#4174) + +## 2.4.0-beta - Major: Added support for emotes, badges, and live emote updates from [7TV](https://7tv.app). [Wiki Page](https://wiki.chatterino.com/Third_party_services/#7tv) (#4002, #4062, #4090) - Major: Added support for Right-to-Left Languages (#3958, #4139, #4168) diff --git a/src/controllers/commands/CommandController.cpp b/src/controllers/commands/CommandController.cpp index 21cb34f5..1ca3c89b 100644 --- a/src/controllers/commands/CommandController.cpp +++ b/src/controllers/commands/CommandController.cpp @@ -2999,18 +2999,11 @@ void CommandController::initialize(Settings &, Paths &paths) auto messagePrefix = QString("The VIPs of this channel are"); - auto entries = QStringList(); - - for (const auto &vip : vipList) - { - entries.append(vip.userName); - } - - entries.sort(Qt::CaseInsensitive); + // TODO: sort results? MessageBuilder builder; TwitchMessageBuilder::listOfUsersSystemMessage( - messagePrefix, entries, twitchChannel, &builder); + messagePrefix, vipList, twitchChannel, &builder); channel->addMessage(builder.release()); },