fix: prefer reporting error over status for 200 OK (#5378)
This commit is contained in:
@@ -37,12 +37,21 @@ TEST(NetworkResult, Errors)
|
||||
"RemoteHostClosedError");
|
||||
|
||||
// status code takes precedence
|
||||
checkResult({Error::TimeoutError, 400, {}}, Error::TimeoutError, 400,
|
||||
"400");
|
||||
checkResult({Error::InternalServerError, 400, {}},
|
||||
Error::InternalServerError, 400, "400");
|
||||
|
||||
// error takes precedence (1..=99)
|
||||
checkResult({Error::BackgroundRequestNotAllowedError, 400, {}},
|
||||
Error::BackgroundRequestNotAllowedError, 400,
|
||||
"BackgroundRequestNotAllowedError");
|
||||
checkResult({Error::UnknownNetworkError, 400, {}},
|
||||
Error::UnknownNetworkError, 400, "UnknownNetworkError");
|
||||
}
|
||||
|
||||
TEST(NetworkResult, InvalidError)
|
||||
{
|
||||
checkResult({static_cast<Error>(-1), {}, {}}, static_cast<Error>(-1),
|
||||
std::nullopt, "unknown error (-1)");
|
||||
checkResult({static_cast<Error>(-1), 42, {}}, static_cast<Error>(-1), 42,
|
||||
"unknown error (status: 42, error: -1)");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user