chatterino2
Code Issues

refactor: add explicit this-> where possible

Browse Source 
I have knowingly skipped some files/portions of files where this would
create merge conflicts for other open PRs.
This commit is contained in:
Rasmus Karlsson
2025-12-30 13:30:57 +01:00
committed by pajlada
parent e0101f71c2
commit 57d6583a2b
64 changed files with 180 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/controllers/notifications/NotificationController.cpp
+9 -9
View File
@@ -64,7 +64,7 @@ void NotificationController::updateChannelNotification(
bool NotificationController::isChannelNotified(const QString &channelName,
Platform p) const
{
return ranges::any_of(channelMap.at(p).raw(), [&](const auto &name) {
return ranges::any_of(this->channelMap.at(p).raw(), [&](const auto &name) {
return name.compare(channelName, Qt::CaseInsensitive) == 0;
});
}
@@ -72,19 +72,19 @@ bool NotificationController::isChannelNotified(const QString &channelName,
void NotificationController::addChannelNotification(const QString &channelName,
Platform p)
{
channelMap[p].append(channelName);
this->channelMap[p].append(channelName);
}
void NotificationController::removeChannelNotification(
const QString &channelName, Platform p)
{
for (std::vector<int>::size_type i = 0; i != channelMap[p].raw().size();
i++)
for (std::vector<int>::size_type i = 0;
i != this->channelMap[p].raw().size(); i++)
{
if (channelMap[p].raw()[i].compare(channelName, Qt::CaseInsensitive) ==
0)
if (this->channelMap[p].raw()[i].compare(channelName,
Qt::CaseInsensitive) == 0)
{
channelMap[p].removeAt(static_cast<int>(i));
this->channelMap[p].removeAt(static_cast<int>(i));
i--;
}
}
@@ -173,9 +173,9 @@ void NotificationController::fetchFakeChannels()
qCDebug(chatterinoNotification) << "fetching fake channels";
QStringList channels;
for (size_t i = 0; i < channelMap[Platform::Twitch].raw().size(); i++)
for (size_t i = 0; i < this->channelMap[Platform::Twitch].raw().size(); i++)
{
const auto &name = channelMap[Platform::Twitch].raw()[i];
const auto &name = this->channelMap[Platform::Twitch].raw()[i];
auto chan = getApp()->getTwitch()->getChannelOrEmpty(name);
if (chan->isEmpty())
{