chatterino2
Code Issues

refactor: Use override instead of virtual where possible (#4917)

Browse Source
This commit is contained in:
pajlada
2023-10-25 18:13:48 +02:00
committed by GitHub
parent da31e47f9a
commit 5c0219c245
54 changed files with 193 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/controllers/accounts/AccountController.hpp
+1 -1
View File
@@ -21,7 +21,7 @@ public:
AccountModel *createModel(QObject *parent);
virtual void initialize(Settings &settings, Paths &paths) override;
void initialize(Settings &settings, Paths &paths) override;
TwitchAccountManager twitch;
src/controllers/accounts/AccountModel.hpp
+8 -9
View File
@@ -17,21 +17,20 @@ public:
protected:
// turn a vector item into a model row
virtual std::shared_ptr<Account> getItemFromRow(
std::shared_ptr<Account> getItemFromRow(
std::vector<QStandardItem *> &row,
const std::shared_ptr<Account> &original) override;
// turns a row in the model into a vector item
virtual void getRowFromItem(const std::shared_ptr<Account> &item,
std::vector<QStandardItem *> &row) override;
void getRowFromItem(const std::shared_ptr<Account> &item,
std::vector<QStandardItem *> &row) override;
virtual int beforeInsert(const std::shared_ptr<Account> &item,
std::vector<QStandardItem *> &row,
int proposedIndex) override;
int beforeInsert(const std::shared_ptr<Account> &item,
std::vector<QStandardItem *> &row,
int proposedIndex) override;
virtual void afterRemoved(const std::shared_ptr<Account> &item,
std::vector<QStandardItem *> &row,
int index) override;
void afterRemoved(const std::shared_ptr<Account> &item,
std::vector<QStandardItem *> &row, int index) override;
friend class AccountController;