chatterino2
Code Issues

refactor: Use override instead of virtual where possible (#4917)

Browse Source
This commit is contained in:
pajlada
2023-10-25 18:13:48 +02:00
committed by GitHub
parent da31e47f9a
commit 5c0219c245
54 changed files with 193 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/controllers/commands/CommandController.hpp
+2 -2
View File
@@ -33,8 +33,8 @@ public:
bool dryRun);
QStringList getDefaultChatterinoCommandList();
virtual void initialize(Settings &, Paths &paths) override;
virtual void save() override;
void initialize(Settings &, Paths &paths) override;
void save() override;
CommandModel *createModel(QObject *parent);
src/controllers/commands/CommandModel.hpp
+4 -4
View File
@@ -22,12 +22,12 @@ class CommandModel : public SignalVectorModel<Command>
protected:
// turn a vector item into a model row
virtual Command getItemFromRow(std::vector<QStandardItem *> &row,
const Command &command) override;
Command getItemFromRow(std::vector<QStandardItem *> &row,
const Command &command) override;
// turns a row in the model into a vector item
virtual void getRowFromItem(const Command &item,
std::vector<QStandardItem *> &row) override;
void getRowFromItem(const Command &item,
std::vector<QStandardItem *> &row) override;
friend class CommandController;
};