chatterino2
Code Issues

refactor: Use override instead of virtual where possible (#4917)

Browse Source
This commit is contained in:
pajlada
2023-10-25 18:13:48 +02:00
committed by GitHub
parent da31e47f9a
commit 5c0219c245
54 changed files with 193 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/controllers/highlights/BadgeHighlightModel.hpp
+4 -5
View File
@@ -25,12 +25,11 @@ public:
protected:
// vector into model row
virtual HighlightBadge getItemFromRow(
std::vector<QStandardItem *> &row,
const HighlightBadge &original) override;
HighlightBadge getItemFromRow(std::vector<QStandardItem *> &row,
const HighlightBadge &original) override;
virtual void getRowFromItem(const HighlightBadge &item,
std::vector<QStandardItem *> &row) override;
void getRowFromItem(const HighlightBadge &item,
std::vector<QStandardItem *> &row) override;
};
} // namespace chatterino
src/controllers/highlights/HighlightBlacklistModel.hpp
+3 -3
View File
@@ -21,13 +21,13 @@ public:
protected:
// turn a vector item into a model row
virtual HighlightBlacklistUser getItemFromRow(
HighlightBlacklistUser getItemFromRow(
std::vector<QStandardItem *> &row,
const HighlightBlacklistUser &original) override;
// turns a row in the model into a vector item
virtual void getRowFromItem(const HighlightBlacklistUser &item,
std::vector<QStandardItem *> &row) override;
void getRowFromItem(const HighlightBlacklistUser &item,
std::vector<QStandardItem *> &row) override;
};
} // namespace chatterino
src/controllers/highlights/HighlightModel.hpp
+8 -9
View File
@@ -42,19 +42,18 @@ public:
protected:
// turn a vector item into a model row
virtual HighlightPhrase getItemFromRow(
std::vector<QStandardItem *> &row,
const HighlightPhrase &original) override;
HighlightPhrase getItemFromRow(std::vector<QStandardItem *> &row,
const HighlightPhrase &original) override;
// turns a row in the model into a vector item
virtual void getRowFromItem(const HighlightPhrase &item,
std::vector<QStandardItem *> &row) override;
void getRowFromItem(const HighlightPhrase &item,
std::vector<QStandardItem *> &row) override;
virtual void afterInit() override;
void afterInit() override;
virtual void customRowSetData(const std::vector<QStandardItem *> &row,
int column, const QVariant &value, int role,
int rowIndex) override;
void customRowSetData(const std::vector<QStandardItem *> &row, int column,
const QVariant &value, int role,
int rowIndex) override;
};
} // namespace chatterino
src/controllers/highlights/UserHighlightModel.hpp
+8 -9
View File
@@ -16,18 +16,17 @@ public:
protected:
// vector into model row
virtual HighlightPhrase getItemFromRow(
std::vector<QStandardItem *> &row,
const HighlightPhrase &original) override;
HighlightPhrase getItemFromRow(std::vector<QStandardItem *> &row,
const HighlightPhrase &original) override;
virtual void getRowFromItem(const HighlightPhrase &item,
std::vector<QStandardItem *> &row) override;
void getRowFromItem(const HighlightPhrase &item,
std::vector<QStandardItem *> &row) override;
virtual void afterInit() override;
void afterInit() override;
virtual void customRowSetData(const std::vector<QStandardItem *> &row,
int column, const QVariant &value, int role,
int rowIndex) override;
void customRowSetData(const std::vector<QStandardItem *> &row, int column,
const QVariant &value, int role,
int rowIndex) override;
};
} // namespace chatterino