fix: sort elements after RTL reordering (#5525)

This commit is contained in:
nerix
2024-07-28 12:29:29 +02:00
committed by GitHub
parent 5fc4309e0e
commit 5ee5abf5b2
4 changed files with 28 additions and 13 deletions
@@ -56,6 +56,8 @@ void MessageLayoutContainer::beginLayout(int width, float scale,
this->currentWordId_ = 0;
this->canAddMessages_ = true;
this->isCollapsed_ = false;
this->lineContainsRTL_ = false;
this->anyReorderingDone_ = false;
}
void MessageLayoutContainer::endLayout()
@@ -105,6 +107,17 @@ void MessageLayoutContainer::endLayout()
{
this->elements_.back()->setTrailingSpace(false);
}
if (this->anyReorderingDone_)
{
std::ranges::sort(this->elements_, [](const auto &a, const auto &b) {
if (a->getLine() == b->getLine())
{
return a->getRect().x() < b->getRect().x();
}
return a->getLine() < b->getLine();
});
}
}
void MessageLayoutContainer::addElement(MessageLayoutElement *element)
@@ -137,6 +150,7 @@ void MessageLayoutContainer::breakLine()
}
}
this->lineContainsRTL_ = false;
this->anyReorderingDone_ = true;
}
int xOffset = 0;
@@ -357,6 +357,9 @@ private:
/// linebreak after which it's reset to `false`.
bool lineContainsRTL_ = false;
/// True if there was any RTL/LTR reordering done in this container
bool anyReorderingDone_ = false;
/// @brief The direction of the text in this container.
///
/// This starts off as neutral until an element is encountered that is