chatterino2
Code Issues

Refactor SplitHeader class (#4276)

Browse Source 
* Flatten static functions in anonymous namespace

* SplitHeader ctor: Rename param

* Header: Remove unnecessary `virtual`s

* auto ptr where possible

* Add curly braces

* Comment twitch room modes

* Treat roomModes->slowMode as an integer

* Remove unused `this` from lambdas

* Add `unsigned int` overload for localizeNumbers

* Move thumbnail max age to a constexpr static & set explicit types

* Explicitly use `QObject::connect`

* Use `empty()` instead of `size()`

* Name unused parameters

* Move moderation action refreshing logic from SplitHeader to Split
This commit is contained in:
pajlada
2022-12-31 12:56:47 +01:00
committed by GitHub
parent 6c1bd1837e
commit 5fc170ba4b
7 changed files with 248 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/splits/SplitHeader.hpp
+10 -10
View File
@@ -25,7 +25,7 @@ class SplitHeader final : public BaseWidget
Q_OBJECT
public:
explicit SplitHeader(Split *_chatWidget);
explicit SplitHeader(Split *split);
void setAddButtonVisible(bool value);
void setViewersButtonVisible(bool value);
@@ -35,16 +35,16 @@ public:
void updateRoomModes();
protected:
virtual void scaleChangedEvent(float) override;
virtual void themeChangedEvent() override;
void scaleChangedEvent(float scale) override;
void themeChangedEvent() override;
virtual void paintEvent(QPaintEvent *) override;
virtual void mousePressEvent(QMouseEvent *event) override;
virtual void mouseReleaseEvent(QMouseEvent *event) override;
virtual void mouseMoveEvent(QMouseEvent *event) override;
virtual void enterEvent(QEvent *) override;
virtual void leaveEvent(QEvent *event) override;
virtual void mouseDoubleClickEvent(QMouseEvent *event) override;
void paintEvent(QPaintEvent *event) override;
void mousePressEvent(QMouseEvent *event) override;
void mouseReleaseEvent(QMouseEvent *event) override;
void mouseMoveEvent(QMouseEvent *event) override;
void enterEvent(QEvent *event) override;
void leaveEvent(QEvent *event) override;
void mouseDoubleClickEvent(QMouseEvent *event) override;
private:
void initializeLayout();