chatterino2
Code Issues

Fix split focusing being broken in certain circumstances when the "Show input when it's empty" setting was disabled (#3838)

Browse Source 
Co-authored-by: Kasia <zneix@zneix.eu>
This commit is contained in:
pajlada
2022-06-26 18:53:09 +02:00
committed by GitHub
parent 8bdfbf7b87
commit 6599009e79
13 changed files with 151 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/splits/SplitContainer.cpp
+4 -4
View File
@@ -206,7 +206,7 @@ void SplitContainer::addSplit(Split *split)
split->setParent(this);
split->show();
split->giveFocus(Qt::MouseFocusReason);
split->setFocus(Qt::FocusReason::MouseFocusReason);
this->unsetCursor();
this->splits_.push_back(split);
@@ -331,7 +331,7 @@ SplitContainer::Position SplitContainer::releaseSplit(Split *split)
}
else
{
this->splits_.front()->giveFocus(Qt::MouseFocusReason);
this->splits_.front()->setFocus(Qt::FocusReason::MouseFocusReason);
}
this->refreshTab();
@@ -414,7 +414,7 @@ void SplitContainer::focusSplitRecursive(Node *node)
switch (node->type_)
{
case Node::_Split: {
node->split_->giveFocus(Qt::OtherFocusReason);
node->split_->setFocus(Qt::FocusReason::OtherFocusReason);
}
break;
@@ -727,7 +727,7 @@ void SplitContainer::focusInEvent(QFocusEvent *)
return;
}
if (this->splits_.size() != 0)
if (!this->splits_.empty())
{
this->splits_.front()->setFocus();
}