chatterino2
Code Issues

Switch some c-style includes to c++-style includes (i.e. stdint.h to

Browse Source 
cstdint)

Make MessageElement to a class to fit better with the derived classes.
Make MessageLayoutElement to a class to fit better with the derived
classes.

Remove virtual from override functions

Replace all instances of boost::signals2 with pajlada::Signals. This
lets us properly use clang code model to check for issues.

Add missing virtual destructor to AbstractIrcServer
Add missing virtual destructor to MessageLayoutElement

Remove unused "connectedConnection" connection in TwitchChannel

Fix typo in TrimChannelName function
Fix typo in MessageParseArgs

Replace some raw pointers with unique pointers where it made more sense.
This allowed us to remove some manually written destructors whose only
purpose was to delete that raw pointer.

Reformat: Add namespace comments
Reformat: Add empty empty lines between main namespace beginning and end
Reformat: Re-order includes
Reformat: Fix some includes that used quotes where they should use angle
brackets
Reformat: Replace some typedef's with using's

Filter out more useless warnings
This commit is contained in:
Rasmus Karlsson
2018-04-03 02:55:32 +02:00
committed by fourtf
parent 1119c08182
commit 6ea3a1df08
103 changed files with 305 additions and 248 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/helper/channelview.hpp
+20 -20
View File
@@ -16,8 +16,8 @@
#include <QTimer>
#include <QWheelEvent>
#include <QWidget>
#include <boost/signals2.hpp>
#include <pajlada/signals/signal.hpp>
#include <unordered_set>
namespace chatterino {
@@ -28,7 +28,7 @@ class ChannelView : public BaseWidget
Q_OBJECT
public:
explicit ChannelView(BaseWidget *parent = 0);
explicit ChannelView(BaseWidget *parent = nullptr);
virtual ~ChannelView();
void queueUpdate();
@@ -49,26 +49,26 @@ public:
void clearMessages();
boost::signals2::signal<void(QMouseEvent *)> mouseDown;
boost::signals2::signal<void()> selectionChanged;
pajlada::Signals::Signal<QMouseEvent *> mouseDown;
pajlada::Signals::NoArgSignal selectionChanged;
pajlada::Signals::NoArgSignal highlightedMessageReceived;
pajlada::Signals::Signal<const messages::Link &> linkClicked;
protected:
virtual void themeRefreshEvent() override;
void themeRefreshEvent() override;
virtual void resizeEvent(QResizeEvent *) override;
void resizeEvent(QResizeEvent *) override;
virtual void paintEvent(QPaintEvent *) override;
virtual void wheelEvent(QWheelEvent *event) override;
void paintEvent(QPaintEvent *) override;
void wheelEvent(QWheelEvent *event) override;
virtual void enterEvent(QEvent *) override;
virtual void leaveEvent(QEvent *) override;
void enterEvent(QEvent *) override;
void leaveEvent(QEvent *) override;
virtual void mouseMoveEvent(QMouseEvent *event) override;
virtual void mousePressEvent(QMouseEvent *event) override;
virtual void mouseReleaseEvent(QMouseEvent *event) override;
virtual void mouseDoubleClickEvent(QMouseEvent *event) override;
void mouseMoveEvent(QMouseEvent *event) override;
void mousePressEvent(QMouseEvent *event) override;
void mouseReleaseEvent(QMouseEvent *event) override;
void mouseDoubleClickEvent(QMouseEvent *event) override;
void handleLinkClick(QMouseEvent *event, const messages::Link &link,
messages::MessageLayout *layout);
@@ -116,12 +116,12 @@ private:
messages::LimitedQueue<messages::MessageLayoutPtr> messages;
boost::signals2::connection messageAppendedConnection;
boost::signals2::connection messageAddedAtStartConnection;
boost::signals2::connection messageRemovedConnection;
boost::signals2::connection messageReplacedConnection;
boost::signals2::connection repaintGifsConnection;
boost::signals2::connection layoutConnection;
pajlada::Signals::Connection messageAppendedConnection;
pajlada::Signals::Connection messageAddedAtStartConnection;
pajlada::Signals::Connection messageRemovedConnection;
pajlada::Signals::Connection messageReplacedConnection;
pajlada::Signals::Connection repaintGifsConnection;
pajlada::Signals::Connection layoutConnection;
std::vector<pajlada::Signals::ScopedConnection> managedConnections;