lazily initialize settings pages

src/widgets/settingspages/AboutPage.cpp

@@ -18,7 +18,6 @@
 namespace chatterino {
 
 AboutPage::AboutPage()
-    : SettingsPage("About")
 {
     LayoutCreator<AboutPage> layoutCreator(this);
 

src/widgets/settingspages/AccountsPage.cpp

@@ -17,7 +17,6 @@
 namespace chatterino {
 
 AccountsPage::AccountsPage()
-    : SettingsPage("Accounts")
 {
     auto *app = getApp();
 

src/widgets/settingspages/CommandPage.cpp

@@ -33,7 +33,6 @@ namespace {
 }  // namespace
 
 CommandPage::CommandPage()
-    : SettingsPage("Commands")
 {
     auto app = getApp();
 

src/widgets/settingspages/ExternalToolsPage.cpp

@@ -12,7 +12,6 @@
 namespace chatterino {
 
 ExternalToolsPage::ExternalToolsPage()
-    : SettingsPage("External tools")
 {
     LayoutCreator<ExternalToolsPage> layoutCreator(this);
     auto layout = layoutCreator.setLayoutType<QVBoxLayout>();

src/widgets/settingspages/GeneralPage.cpp

@@ -237,7 +237,6 @@ bool SettingsLayout::filterElements(const QString &query)
 }
 
 GeneralPage::GeneralPage()
-    : SettingsPage("General")
 {
     auto y = new QVBoxLayout;
     auto scroll = new QScrollArea;
@@ -263,9 +262,7 @@ GeneralPage::GeneralPage()
 bool GeneralPage::filterElements(const QString &query)
 {
     if (this->settingsLayout_)
-        return this->settingsLayout_->filterElements(query) ||
-               this->name_.contains(query, Qt::CaseInsensitive) ||
-               query.isEmpty();
+        return this->settingsLayout_->filterElements(query) || query.isEmpty();
     else
         return false;
 }

src/widgets/settingspages/HighlightingPage.cpp

@@ -29,7 +29,6 @@
 namespace chatterino {
 
 HighlightingPage::HighlightingPage()
-    : SettingsPage("Highlights")
 {
     auto app = getApp();
     LayoutCreator<HighlightingPage> layoutCreator(this);

src/widgets/settingspages/IgnoresPage.cpp

@@ -29,7 +29,6 @@ static void addUsersTab(IgnoresPage &page, LayoutCreator<QVBoxLayout> box,
                         QStringListModel &model);
 
 IgnoresPage::IgnoresPage()
-    : SettingsPage("Ignores")
 {
     LayoutCreator<IgnoresPage> layoutCreator(this);
     auto layout = layoutCreator.setLayoutType<QVBoxLayout>();

src/widgets/settingspages/KeyboardSettingsPage.cpp

@@ -8,7 +8,6 @@
 namespace chatterino {
 
 KeyboardSettingsPage::KeyboardSettingsPage()
-    : SettingsPage("Keybindings")
 {
     auto layout =
         LayoutCreator<KeyboardSettingsPage>(this).setLayoutType<QVBoxLayout>();

src/widgets/settingspages/ModerationPage.cpp

@@ -73,7 +73,6 @@ QString fetchLogDirectorySize()
 }
 
 ModerationPage::ModerationPage()
-    : SettingsPage("Moderation")
 {
     auto app = getApp();
     LayoutCreator<ModerationPage> layoutCreator(this);

src/widgets/settingspages/NotificationPage.cpp

@@ -21,7 +21,6 @@
 namespace chatterino {
 
 NotificationPage::NotificationPage()
-    : SettingsPage("Notifications")
 {
     LayoutCreator<NotificationPage> layoutCreator(this);
     auto layout = layoutCreator.emplace<QVBoxLayout>().withoutMargin();

src/widgets/settingspages/SettingsPage.cpp

@@ -64,20 +64,13 @@ bool filterItemsRec(QObject *object, const QString &query)
     return any;
 }
 
-SettingsPage::SettingsPage(const QString &name)
-    : name_(name)
+SettingsPage::SettingsPage()
 {
 }
 
 bool SettingsPage::filterElements(const QString &query)
 {
-    return filterItemsRec(this, query) || query.isEmpty() ||
-           this->name_.contains(query, Qt::CaseInsensitive);
-}
-
-const QString &SettingsPage::getName()
-{
-    return this->name_;
+    return filterItemsRec(this, query) || query.isEmpty();
 }
 
 SettingsDialogTab *SettingsPage::tab() const

src/widgets/settingspages/SettingsPage.hpp

@@ -47,9 +47,7 @@ class SettingsPage : public QFrame
     Q_OBJECT
 
 public:
-    SettingsPage(const QString &name);
-
-    const QString &getName();
+    SettingsPage();
 
     virtual bool filterElements(const QString &query);
 
@@ -71,7 +69,6 @@ public:
     }
 
 protected:
-    QString name_;
     SettingsDialogTab *tab_;
     pajlada::Signals::NoArgSignal onCancel_;
     std::vector<pajlada::Signals::ScopedConnection> managedConnections_;