added insecure credential store

src/widgets/Window.cpp

@@ -1,6 +1,7 @@
 #include "widgets/Window.hpp"
 
 #include "Application.hpp"
+#include "common/Credentials.hpp"
 #include "common/Version.hpp"
 #include "controllers/accounts/AccountController.hpp"
 #include "providers/twitch/TwitchServer.hpp"
@@ -103,7 +104,7 @@ bool Window::event(QEvent *event)
         break;
 
         default:;
-    };
+    }
 
     return BaseWindow::event(event);
 }

src/widgets/dialogs/IrcConnectionPopup.cpp

@@ -1,38 +0,0 @@
-#include "IrcConnectionPopup.hpp"
-
-#include "providers/irc/Irc2.hpp"
-#include "util/LayoutHelper.hpp"
-#include "widgets/helper/EditableModelView.hpp"
-
-#include <QHBoxLayout>
-#include <QTableView>
-
-namespace chatterino {
-
-IrcConnectionPopup::IrcConnectionPopup(QWidget *parent)
-    : BaseWindow(parent, BaseWindow::Flags::EnableCustomFrame)
-{
-    this->setWindowTitle("Edit Irc Connections");
-
-    // view
-    auto view =
-        new EditableModelView(Irc::getInstance().newConnectionModel(this));
-
-    view->setTitles({"host", "port", "ssl", "user", "nick", "password"});
-    view->getTableView()->horizontalHeader()->resizeSection(0, 140);
-    view->getTableView()->horizontalHeader()->resizeSection(1, 30);
-    view->getTableView()->horizontalHeader()->resizeSection(2, 30);
-
-    this->setScaleIndependantSize(800, 500);
-
-    view->addButtonPressed.connect([] {
-        auto unique = IrcServerData{};
-        unique.id = Irc::getInstance().uniqueId();
-        Irc::getInstance().connections.appendItem(unique);
-    });
-
-    // init layout
-    this->getLayoutContainer()->setLayout(makeLayout<QHBoxLayout>({view}));
-}
-
-}  // namespace chatterino

src/widgets/dialogs/IrcConnectionPopup.hpp

@@ -1,13 +0,0 @@
-#pragma once
-
-#include "widgets/BaseWindow.hpp"
-
-namespace chatterino {
-
-class IrcConnectionPopup : public BaseWindow
-{
-public:
-    IrcConnectionPopup(QWidget *parent);
-};
-
-}  // namespace chatterino

src/widgets/dialogs/SelectChannelDialog.cpp

@@ -6,7 +6,6 @@
 #include "util/LayoutCreator.hpp"
 #include "widgets/Notebook.hpp"
 #include "widgets/dialogs/IrcConnectionEditor.hpp"
-#include "widgets/dialogs/IrcConnectionPopup.hpp"
 #include "widgets/helper/NotebookTab.hpp"
 
 #include <QDialogButtonBox>

src/widgets/settingspages/GeneralPage.cpp

@@ -377,6 +377,15 @@ void GeneralPage::initLayout(SettingsLayout &layout)
 
     layout.addTitle("Miscellaneous");
 
+#ifdef Q_OS_LINUX
+    if (!getPaths()->isPortable())
+    {
+        layout.addCheckbox(
+            "Use libsecret/KWallet/Gnome keychain to secure passwords",
+            s.useKeyring);
+    }
+#endif
+
     layout.addCheckbox("Show moderation messages", s.hideModerationActions,
                        true);
     layout.addCheckbox("Random username color for users who never set a color",