From 804bc526b52b5c4996d1d449194074934bc8d529 Mon Sep 17 00:00:00 2001 From: fourtf Date: Sat, 3 Jul 2021 22:11:10 +0200 Subject: [PATCH] fix overflows in the max image size code (#2950) * fix overflows in the max image size code * Update Image.cpp --- src/messages/Image.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/messages/Image.cpp b/src/messages/Image.cpp index 9147bbea..1b4f1164 100644 --- a/src/messages/Image.cpp +++ b/src/messages/Image.cpp @@ -406,9 +406,10 @@ void Image::actuallyLoad() buffer.open(QIODevice::ReadOnly); QImageReader reader(&buffer); - if (reader.size().width() * reader.size().height() * - reader.imageCount() * 4 > - Image::maxBytesRam) + // use "double" to prevent int overflows + if (double(reader.size().width()) * double(reader.size().height()) * + double(reader.imageCount()) * 4.0 > + double(Image::maxBytesRam)) { qCDebug(chatterinoImage) << "image too large in RAM";