chatterino2
Code Issues

Fix signal connection nodiscard warnings (#4818)

Browse Source
This commit is contained in:
pajlada
2023-09-16 13:52:51 +02:00
committed by GitHub
parent 2d5f078306
commit 8fe3af3522
40 changed files with 709 additions and 554 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/singletons/Logging.cpp
+13 -8
View File
@@ -14,16 +14,21 @@ namespace chatterino {
void Logging::initialize(Settings &settings, Paths & /*paths*/)
{
settings.loggedChannels.delayedItemsChanged.connect([this, &settings]() {
this->threadGuard.guard();
// We can safely ignore this signal connection since settings are only-ever destroyed
// on application exit
// NOTE: SETTINGS_LIFETIME
std::ignore = settings.loggedChannels.delayedItemsChanged.connect(
[this, &settings]() {
this->threadGuard.guard();
this->onlyLogListedChannels.clear();
this->onlyLogListedChannels.clear();
for (const auto &loggedChannel : *settings.loggedChannels.readOnly())
{
this->onlyLogListedChannels.insert(loggedChannel.channelName());
}
});
for (const auto &loggedChannel :
*settings.loggedChannels.readOnly())
{
this->onlyLogListedChannels.insert(loggedChannel.channelName());
}
});
}
void Logging::addMessage(const QString &channelName, MessagePtr message,