Fix signal connection nodiscard warnings (#4818)

2023-09-16 13:52:51 +02:00
parent 2d5f078306
commit 8fe3af3522
40 changed files with 709 additions and 554 deletions
@@ -246,7 +246,9 @@ EmotePopup::EmotePopup(QWidget *parent)
            MessageElementFlag::Default, MessageElementFlag::AlwaysShow,
            MessageElementFlag::EmoteImages});
        view->setEnableScrollingToBottom(false);
-        view->linkClicked.connect(clicked);
+        // We can safely ignore this signal connection since the ChannelView is deleted
+        // either when the notebook is deleted, or when our main layout is deleted.
+        std::ignore = view->linkClicked.connect(clicked);

        if (addToNotebook)
        {