From 93a6c55ed34614009dee95aa95d98bbab46cc4bb Mon Sep 17 00:00:00 2001 From: Leon Richardt Date: Sun, 26 Jan 2020 10:08:25 +0100 Subject: [PATCH] Fix subscription messages triggering split highlights (#1519) Since #1320, subscription messages are treated as highlights in order to allow customization. This caused subscription messages to highlight the split(s) the message was received in. This is not intended behavior. This commit fixes the issue by additionally checking if the `Subscription` flag is set on a highlighted message. --- src/widgets/helper/ChannelView.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/widgets/helper/ChannelView.cpp b/src/widgets/helper/ChannelView.cpp index 3fe02bfb..c2542354 100644 --- a/src/widgets/helper/ChannelView.cpp +++ b/src/widgets/helper/ChannelView.cpp @@ -648,7 +648,8 @@ void ChannelView::messageAppended(MessagePtr &message, if (!messageFlags->has(MessageFlag::DoNotTriggerNotification)) { - if (messageFlags->has(MessageFlag::Highlighted)) + if (messageFlags->has(MessageFlag::Highlighted) && + !messageFlags->has(MessageFlag::Subscription)) { this->tabHighlightRequested.invoke(HighlightState::Highlighted); }