chatterino2
Code Issues

fix: more MSVC warnings (#5137)

Browse Source
This commit is contained in:
nerix
2024-01-30 17:28:36 +01:00
committed by GitHub
parent a5e853573f
commit 954e19817c
17 changed files with 59 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/widgets/settingspages/GeneralPageView.hpp
+2 -2
View File
@@ -220,9 +220,9 @@ public:
{
auto *combo = this->addDropdown(text, {}, std::move(toolTipText));
for (const auto &[text, userData] : items)
for (const auto &[itemText, userData] : items)
{
combo->addItem(text, userData);
combo->addItem(itemText, userData);
}
if (!defaultValueText.isEmpty())
src/widgets/splits/SplitContainer.cpp
+4 -3
View File
@@ -869,10 +869,11 @@ void SplitContainer::applyFromDescriptorRecursively(
auto *node = new Node();
node->parent_ = baseNode;
if (const auto *n = std::get_if<ContainerNodeDescriptor>(&item))
if (const auto *inner =
std::get_if<ContainerNodeDescriptor>(&item))
{
node->flexH_ = n->flexH_;
node->flexV_ = n->flexV_;
node->flexH_ = inner->flexH_;
node->flexV_ = inner->flexV_;
}
baseNode->children_.emplace_back(node);